Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Link/TelemetrySpan to accept SpanAttributes #1120

Merged
merged 12 commits into from
Aug 21, 2020
Merged

Updating Link/TelemetrySpan to accept SpanAttributes #1120

merged 12 commits into from
Aug 21, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Aug 20, 2020 •
edited
Loading

Fixes #1119.
Fixes #1117.

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Aug 20, 2020 •
edited
Loading

Codecov Report

Merging #1120 into master will decrease coverage by 0.18%.
The diff coverage is 48.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1120      +/-   ##
==========================================
- Coverage   77.74%   77.55%   -0.19%     
==========================================
  Files         222      222              
  Lines        6267     6282      +15     
==========================================
  Hits         4872     4872              
- Misses       1395     1410      +15
Impacted Files Coverage Δ
src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs 78.84% <35.00%> (-10.81%) ⬇️
src/OpenTelemetry.Api/Trace/Link.cs 100.00% <100.00%> (ø)
src/OpenTelemetry.Api/Trace/TelemetrySpan.cs 83.58% <100.00%> (-0.48%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 77.77% <0.00%> (-3.18%) ⬇️

@eddynaka eddynaka marked this pull request as ready for review August 20, 2020 23:22
@eddynaka eddynaka requested a review from a team August 20, 2020 23:22
@eddynaka eddynaka changed the title Feature/updating to spanattributes Updating Link to Accept SpanAttributes instead of ActivityTagsCollection Aug 21, 2020
@eddynaka eddynaka changed the title Updating Link to Accept SpanAttributes instead of ActivityTagsCollection Updating Link/TelemetrySpan to accept SpanAttributes Aug 21, 2020
CodeBlanch
CodeBlanch approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit c75d85b into open-telemetry:master Aug 21, 2020
@eddynaka eddynaka deleted the feature/updating-to-spanattributes branch August 24, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@pjanotti pjanotti Awaiting requested review from pjanotti

@cijothomas cijothomas Awaiting requested review from cijothomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@eddynaka @MikeGoldsmith @cijothomas @pjanotti @CodeBlanch