Skip to content

Commit

Permalink
Rename MetricExportInterval to MtricExportIntervalMilliSeconds
Browse files Browse the repository at this point in the history
  • Loading branch information
utpilla committed Jul 26, 2021
1 parent 28f59eb commit 66c86e7
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions examples/Console/TestMetrics.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ internal static object Run(MetricsOptions options)
providerBuilder
.AddOtlpExporter(o =>
{
o.MetricExportInterval = options.DefaultCollectionPeriodMilliseconds;
o.MetricExportIntervalMilliSeconds = options.DefaultCollectionPeriodMilliseconds;
o.IsDelta = options.IsDelta;
});
}
Expand All @@ -75,7 +75,7 @@ internal static object Run(MetricsOptions options)
providerBuilder
.AddConsoleExporter(o =>
{
o.MetricExportInterval = options.DefaultCollectionPeriodMilliseconds;
o.MetricExportIntervalMilliSeconds = options.DefaultCollectionPeriodMilliseconds;
o.IsDelta = options.IsDelta;
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public static MeterProviderBuilder AddConsoleExporter(this MeterProviderBuilder

var options = new ConsoleExporterOptions();
configure?.Invoke(options);
return builder.AddMetricProcessor(new PushMetricProcessor(new ConsoleMetricExporter(options), options.MetricExportInterval, options.IsDelta));
return builder.AddMetricProcessor(new PushMetricProcessor(new ConsoleMetricExporter(options), options.MetricExportIntervalMilliSeconds, options.IsDelta));
}
}
}
4 changes: 2 additions & 2 deletions src/OpenTelemetry.Exporter.Console/ConsoleExporterOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ public class ConsoleExporterOptions
public ConsoleExporterOutputTargets Targets { get; set; } = ConsoleExporterOutputTargets.Console;

/// <summary>
/// Gets or sets the metric export interval.
/// Gets or sets the metric export interval in milliseconds. The default value is 1000 milliseconds.
/// </summary>
public int MetricExportInterval { get; set; } = 1000;
public int MetricExportIntervalMilliSeconds { get; set; } = 1000;

/// <summary>
/// Gets or sets a value indicating whether to export Delta
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public static MeterProviderBuilder AddInMemoryExporter(this MeterProviderBuilder

var options = new InMemoryExporterOptions();
configure?.Invoke(options);
return builder.AddMetricProcessor(new PushMetricProcessor(new InMemoryExporter<MetricItem>(exportedItems), options.MetricExportInterval, options.IsDelta));
return builder.AddMetricProcessor(new PushMetricProcessor(new InMemoryExporter<MetricItem>(exportedItems), options.MetricExportIntervalMilliSeconds, options.IsDelta));
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ namespace OpenTelemetry.Exporter
public class InMemoryExporterOptions
{
/// <summary>
/// Gets or sets the metric export interval.
/// Gets or sets the metric export interval in milliseconds. The default value is 1000 milliseconds.
/// </summary>
public int MetricExportInterval { get; set; } = 1000;
public int MetricExportIntervalMilliSeconds { get; set; } = 1000;

/// <summary>
/// Gets or sets a value indicating whether to export Delta
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ public class OtlpExporterOptions
public BatchExportProcessorOptions<Activity> BatchExportProcessorOptions { get; set; } = new BatchExportProcessorOptions<Activity>();

/// <summary>
/// Gets or sets the metric export interval.
/// Gets or sets the metric export interval in milliseconds. The default value is 1000 milliseconds.
/// </summary>
public int MetricExportInterval { get; set; } = 1000;
public int MetricExportIntervalMilliSeconds { get; set; } = 1000;

/// <summary>
/// Gets or sets a value indicating whether to export Delta
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public static MeterProviderBuilder AddOtlpExporter(this MeterProviderBuilder bui

var options = new OtlpExporterOptions();
configure?.Invoke(options);
return builder.AddMetricProcessor(new PushMetricProcessor(new OtlpMetricsExporter(options), options.MetricExportInterval, options.IsDelta));
return builder.AddMetricProcessor(new PushMetricProcessor(new OtlpMetricsExporter(options), options.MetricExportIntervalMilliSeconds, options.IsDelta));
}
}
}

0 comments on commit 66c86e7

Please sign in to comment.