Don't create ActivityContext struct for comparison

open-telemetry · Dec 21, 2023 · 2aa9fd9 · 2aa9fd9
1 parent 462287e
commit 2aa9fd9
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs b/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
@@ -118,11 +118,10 @@ public void OnStartActivity(Activity activity, object payload)
         if (textMapPropagator is not TraceContextPropagator)
         {
             var ctx = textMapPropagator.Extract(default, request, HttpRequestHeaderValuesGetter);
-            var activityContext = new ActivityContext(activity.TraceId, activity.ParentSpanId, activity.ActivityTraceFlags, activity.TraceStateString, true);
             if (ctx.ActivityContext.IsValid()
-                && !((ctx.ActivityContext.TraceId == activityContext.TraceId)
-                    && (ctx.ActivityContext.SpanId == activityContext.SpanId)
-                    && (ctx.ActivityContext.TraceState == activityContext.TraceState)))
+                && !((ctx.ActivityContext.TraceId == activity.TraceId)
+                    && (ctx.ActivityContext.SpanId == activity.ParentSpanId)
+                    && (ctx.ActivityContext.TraceState == activity.TraceStateString)))
             {
                 // Create a new activity with its parent set from the extracted context.
                 // This makes the new activity as a "sibling" of the activity created by