Update changelog and tests

open-telemetry · Sep 9, 2022 · 2a8373a · 2a8373a
1 parent 8e349c1
commit 2a8373a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md b/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Bug fix for Prometheus Exporter reporting StatusCode 204
+instead of 200, when no metrics are collected
+
 ## 1.4.0-alpha.2
 
 Released 2022-Aug-18

diff --git a/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md b/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Bug fix for Prometheus Exporter reporting StatusCode 204
+instead of 200, when no metrics are collected
+
 ## 1.4.0-alpha.2
 
 Released 2022-Aug-18

diff --git a/test/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests/PrometheusExporterMiddlewareTests.cs b/test/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests/PrometheusExporterMiddlewareTests.cs
@@ -281,7 +281,7 @@ private static async Task RunPrometheusExporterMiddlewareIntegrationTest(
             }
             else
             {
-                Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
+                Assert.Equal(HttpStatusCode.Ok, response.StatusCode);
             }
 
             validateResponse?.Invoke(response);

diff --git a/test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/PrometheusHttpListenerTests.cs b/test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/PrometheusHttpListenerTests.cs
@@ -140,7 +140,7 @@ private async Task RunPrometheusExporterHttpServerIntegrationTest(bool skipMetri
             }
             else
             {
-                Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
+                Assert.Equal(HttpStatusCode.Ok, response.StatusCode);
             }
         }
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
                 else
                 {
-                    Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
+                    Assert.Equal(HttpStatusCode.Ok, response.StatusCode);
                 }
                 validateResponse?.Invoke(response);
@@ Expand Down @@