Fix ASP.NET Core Traces Instrumentation for .NET7+ #3231
Conversation
|
As a follow up for this PR we should revisit strategy for loading other |
Kielek
changed the title
Kielek
force-pushed
the
fix-aspnetcore-instrumentation
branch
from
4bbc054 to
e855afe
Compare
Use semi-native support by Microsoft.AspNetCore
Kielek
force-pushed
the
fix-aspnetcore-instrumentation
branch
from
e855afe to
7da059f
Compare
test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux.verified.txt
Outdated
Show resolved
Hide resolved
| @@ -37,7 +37,11 @@ public void SubmitTraces(string propagators) | |||
| return true; | |||
| }); | |||
| Span? serverSpan = null; | |||
| #if NET7_0_OR_GREATER | |||
| collector.Expect("Microsoft.AspNetCore", span => | |||
There was a problem hiding this comment.
Can we solve this in a way that we can always use the same instrumentation source?
There was a problem hiding this comment.
It is not "our" decision. The difference comes from the (semi)native support for ASP.NET Core instrumentation in net7+ and from "OpenTelemetry.Instrumentation.AspNetCore" package.
I do not see possibility to have the same source for both versions. BTW same case is for http(client) instrumentation (already covered),
| @@ -3,5 +3,6 @@ | |||
| <PackageReference Include="System.Diagnostics.DiagnosticSource" /> | |||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" /> | |||
| <PackageReference Include="Microsoft.Extensions.Logging.Configuration" /> | |||
| <PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" /> | |||
There was a problem hiding this comment.
OpenTelemetry.Instrumentation.AspNetCore has a dependency on web components like Microsoft.AspNetCore.App. When AdditionalDeps is applied to other .NET type applications, it may interfere with those applications. Therefore, it is not recommended to include web components in the store for auto-instrumentation purposes.
There was a problem hiding this comment.
Do you see better idea to load dependecy targeted fo .NET7 in net7 runtime?
Based on what I see in store chnages, there is no new libraries included into it. I will double check it tommorow.
…ate items or use the Update functionality to ensure a consistent restore behavior. The duplicate 'PackageVersion' items are: Microsoft.Extensions.Logging.Abstractions 8.0.0, Microsoft.Extensions.Logging.Abstractions 8.0.0; Microsoft.Extensions.Logging.Configuration 8.0.0, Microsoft.Extensions.
|
Handled by #3246 |
Why
Fixes #3212
Handles changes from open-telemetry/opentelemetry-dotnet#3391
What
Fixes AspNetCore Instrumentation for traces for .NET7.
It is now producing
Microsoft.AspNetCoreas it should.What is more
OpenTelemetry.Instrumentation.AspNetCoreand its dependencies is loaded from additional store. It has to be loaded with dedicated-compiled version for each .NET version.Tests
Modified CI.
Checklist
CHANGELOG.mdis updated.[ ] Documentation is updated.Newfeatures are covered by tests.