-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Process] Exposed required metric process.cpu.count
for computing CPU utilization in the backend.
#981
[Instrumentation.Process] Exposed required metric process.cpu.count
for computing CPU utilization in the backend.
#981
Conversation
Can we open discussion on spec side once more time? The minimal effort - decide the name in the spec side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.processors
is kind of tongue twister 🤣 process.cpu.count
is much nicer IMO. Probably process.threads
-> process.thread.count
would also be good.
I've created an issue in the spec side! |
process.processors
for computing CPU utilization in the backend.process.processors
for computing CPU utilization in the backend. (pending spec discussion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the spec dependency is not a blocker IMHO given the component and the spec are both preview/experimental.
process.processors
for computing CPU utilization in the backend. (pending spec discussion)process.processors
for computing CPU utilization in the backend.
Co-authored-by: Cijo Thomas <[email protected]>
process.processors
for computing CPU utilization in the backend.process.cpu.count
for computing CPU utilization in the backend.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main open-telemetry/opentelemetry-specification#981 +/- ##
==========================================
+ Coverage 68.11% 68.13% +0.02%
==========================================
Files 184 184
Lines 7013 7021 +8
==========================================
+ Hits 4777 4784 +7
- Misses 2236 2237 +1
|
Co-authored-by: Reiley Yang <[email protected]>
Based on spec discussion: open-telemetry/opentelemetry-specification#2392 (comment)
Related to: #972.
Changes
Exposed required metric
process.processors
for computing CPU utilization in the backend.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes