Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Nulls on Contrib.Extensions.AWSXRay & Test Projects #920

Merged
merged 13 commits into from
Feb 24, 2023

Conversation

FernandoNunes
Copy link
Contributor

Fixes #.

Changes

Enabled Nulls (enable) on Contrib.Extensions.AWSXRay & Test Projects

@FernandoNunes FernandoNunes requested a review from a team January 24, 2023 10:19
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@Kielek
Copy link
Contributor

Kielek commented Jan 24, 2023

@FernandoNunes, please sign CLA, without this we want be able to merge your code.

I have approved run, but I expect a lot of issues related to the nullability part.

@FernandoNunes
Copy link
Contributor Author

Hi @Kielek , I didn't noticed the project had warnings, my bad. I've commited the changes required for nullability checks and all tests are passing (netcoreapp3.1 & net452).

Also, I've signed the CLA.

@Kielek Kielek added the comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS label Jan 24, 2023
@Kielek
Copy link
Contributor

Kielek commented Jan 25, 2023

There are some compilation issues. Could you please address it?

@FernandoNunes
Copy link
Contributor Author

There are some compilation issues. Could you please address it?

Added missing #nullable enable
Sorry still getting the hang of it, I'll be more efficient next PRs.

@FernandoNunes
Copy link
Contributor Author

Visual Studio suggests the fixes to PublicAPI but doesn't changes for all platform's PublicAPI.txts.
After all changes are applied to one, I've started reviewing them all by hand for all platforms.

@Kielek
Copy link
Contributor

Kielek commented Jan 26, 2023

Visual Studio suggests the fixes to PublicAPI but doesn't changes for all platform's PublicAPI.txts. After all changes are applied to one, I've started reviewing them all by hand for all platforms.

Unfortunately, it is the only way I know how to fix it.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 10, 2023
@Kielek Kielek removed the Stale label Feb 10, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 23, 2023
@srprash
Copy link
Contributor

srprash commented Feb 24, 2023

@FernandoNunes The changes look good to me. Can you resolve the conflicts on this PR? Thanks!

@utpilla utpilla removed the Stale label Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #920 (c96b0ec) into main (e6a714d) will decrease coverage by 0.02%.
The diff coverage is 90.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   69.46%   69.44%   -0.02%     
==========================================
  Files         202      202              
  Lines        7663     7668       +5     
==========================================
+ Hits         5323     5325       +2     
- Misses       2340     2343       +3     
Impacted Files Coverage Δ
...y.Contrib.Extensions.AWSXRay/AWSXRayIdGenerator.cs 61.64% <ø> (ø)
...ources/Http/ServerCertificateValidationProvider.cs 60.00% <50.00%> (-1.30%) ⬇️
...ntrib.Extensions.AWSXRay/Resources/Http/Handler.cs 70.58% <66.66%> (-2.75%) ⬇️
...nsions.AWSXRay/Resources/AWSEKSResourceDetector.cs 57.14% <83.33%> (ø)
...nsions.AWSXRay/Resources/AWSEBSResourceDetector.cs 87.50% <100.00%> (ø)
...nsions.AWSXRay/Resources/AWSEC2ResourceDetector.cs 68.96% <100.00%> (ø)
...nsions.AWSXRay/Resources/AWSECSResourceDetector.cs 67.85% <100.00%> (ø)
...ons.AWSXRay/Resources/AWSLambdaResourceDetector.cs 84.21% <100.00%> (ø)
...ns.AWSXRay/Resources/Models/AWSEBSMetadataModel.cs 100.00% <100.00%> (ø)
...ay/Resources/Models/AWSEC2IdentityDocumentModel.cs 100.00% <100.00%> (ø)
... and 3 more

@FernandoNunes
Copy link
Contributor Author

@FernandoNunes The changes look good to me. Can you resolve the conflicts on this PR? Thanks!

All checks have passed. After this one can you check other PRs I have open ? :)

@utpilla utpilla merged commit e280873 into open-telemetry:main Feb 24, 2023
@FernandoNunes FernandoNunes deleted the EnableNulls branch March 3, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants