-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Nulls on Contrib.Extensions.AWSXRay & Test Projects #920
Conversation
@FernandoNunes, please sign CLA, without this we want be able to merge your code. I have approved run, but I expect a lot of issues related to the nullability part. |
Hi @Kielek , I didn't noticed the project had warnings, my bad. I've commited the changes required for nullability checks and all tests are passing (netcoreapp3.1 & net452). Also, I've signed the CLA. |
There are some compilation issues. Could you please address it? |
Added missing #nullable enable |
Visual Studio suggests the fixes to PublicAPI but doesn't changes for all platform's PublicAPI.txts. |
Unfortunately, it is the only way I know how to fix it. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@FernandoNunes The changes look good to me. Can you resolve the conflicts on this PR? Thanks! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
- Coverage 69.46% 69.44% -0.02%
==========================================
Files 202 202
Lines 7663 7668 +5
==========================================
+ Hits 5323 5325 +2
- Misses 2340 2343 +3
|
All checks have passed. After this one can you check other PRs I have open ? :) |
Fixes #.
Changes
Enabled Nulls (enable) on Contrib.Extensions.AWSXRay & Test Projects