[EventCounters] SpinWait for tests #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
utpilla
added
the
comp:instrumentation.eventcounters
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
+ Coverage 68.33% 68.38% +0.04%
==========================================
Files 183 183
Lines 7024 7025 +1
==========================================
+ Hits 4800 4804 +4
+ Misses 2224 2221 -3
|
test/OpenTelemetry.Instrumentation.EventCounters.Tests/EventCountersMetricsTests.cs
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.EventCounters.Tests/EventCountersMetricsTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.EventCounters.Tests/EventCountersMetricsTests.cs
Show resolved
Hide resolved
vishweshbankwar
approved these changes
Jan 30, 2023
cijothomas
reviewed
Jan 30, 2023
| @@ -64,11 +45,9 @@ public void EventCounter() | |||
|
|
|||
| // Act | |||
| counter.WriteMetric(1997.0202); | |||
| Task.Delay(Delay).Wait(); | |||
| meterProvider.ForceFlush(); | |||
| var metric = AwaitExport(meterProvider, metricItems, expectedInstrumentName: "ec.a.c"); | |||
There was a problem hiding this comment.
why no flush first before await?
cijothomas
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763 and #910
Changes
Use
SpinWaitinstead ofTask.Delayfor a metric item to be exported.The key was to spin until the metric item with the expected name was in the collection since the collection is being populated by all other instruments so simply checking for a count being greater than 1 would not work. Especially in the
Theorytest case.