Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exporter.Stackdriver] Update dependencies #794

Merged
merged 10 commits into from
Nov 30, 2022
Merged

[Exporter.Stackdriver] Update dependencies #794

merged 10 commits into from
Nov 30, 2022

Conversation

trenslow
Copy link
Contributor

Fixes #783.

Changes

Update of underlying Google dependencies to be more in line with potential other Google dependencies used in the same project as the Stackdriver exporter.

@trenslow trenslow requested a review from a team November 23, 2022 13:46
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 23, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: trenslow / name: Tyler Renslow (c01a922)

@Kielek
Copy link
Contributor

Kielek commented Nov 23, 2022

Please update also CHANGELOG.md - Unreleased section. Short change description + link to this PR is needed.

@Kielek Kielek added the comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver label Nov 23, 2022
@Kielek Kielek changed the title Update OpenTelemetry.Exporter.Stackdriver.csproj [Exporter.Stackdriver] Update dependencies Nov 23, 2022
@trenslow
Copy link
Contributor Author

@Kielek CHANGELOG.md updated :)

@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #794 (8f14ef6) into main (f48c05f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 8f14ef6 differs from pull request most recent head d400644. Consider uploading reports for the commit d400644 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   77.99%   77.97%   -0.02%     
==========================================
  Files         176      176              
  Lines        5312     5313       +1     
==========================================
  Hits         4143     4143              
- Misses       1169     1170       +1
Impacted Files Coverage Δ
...er.Geneva/MsgPackExporter/MessagePackSerializer.cs 91.82% <0.00%> (-0.45%) ⬇️

@trenslow
Copy link
Contributor Author

@utpilla updated the files with your request

@trenslow
Copy link
Contributor Author

@utpilla @Kielek what's the latest status on this PR?

@utpilla utpilla merged commit 4a0cda8 into open-telemetry:main Nov 30, 2022
@trenslow trenslow deleted the patch-1 branch December 1, 2022 08:03
@trenslow
Copy link
Contributor Author

trenslow commented Dec 7, 2022

@utpilla when can we expect a release with these updates? No rush from my side, just for planning purposes :)

@Kielek
Copy link
Contributor

Kielek commented Dec 7, 2022

@trenslow, please create PR with the request https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package

Example: #800

New release should be 1.0.0-beta.4

@trenslow trenslow mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

@utpilla utpilla utpilla approved these changes

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Google.* nugets
4 participants
@trenslow @Kielek @utpilla @SergeyKanzhelev