Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore Activity.Current before all IIS LifeCycle events #761

Merged
merged 1 commit into from
Nov 17, 2022
Merged

restore Activity.Current before all IIS LifeCycle events #761

merged 1 commit into from
Nov 17, 2022

Conversation

chris-smith-zocdoc
Copy link
Contributor

@chris-smith-zocdoc chris-smith-zocdoc requested a review from a team November 8, 2022 15:53
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 8, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: chris-smith-zocdoc / name: Chris Smith (0c156b3)

@chris-smith-zocdoc chris-smith-zocdoc mentioned this pull request Nov 8, 2022
Closed
@utpilla utpilla added the comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet label Nov 8, 2022
@utpilla utpilla requested a review from CodeBlanch November 8, 2022 21:13
@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Merging #761 (2b2f539) into main (40a3df3) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 2b2f539 differs from pull request most recent head 775de77. Consider uploading reports for the commit 775de77 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   77.58%   77.59%   +0.01%     
==========================================
  Files         176      176              
  Lines        5313     5312       -1     
==========================================
  Hits         4122     4122              
+ Misses       1191     1190       -1
Impacted Files Coverage Δ
....AspNet.TelemetryHttpModule/TelemetryHttpModule.cs 5.40% <0.00%> (+0.14%) ⬆️

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 16, 2022
@chris-smith-zocdoc
Copy link
Contributor Author

not stale

@CodeBlanch
Copy link
Member

@chris-smith-zocdoc Would you please add a note about the change in the project CHANGELOG?

@github-actions github-actions bot removed the Stale label Nov 17, 2022
@chris-smith-zocdoc
Copy link
Contributor Author

@CodeBlanch done

CodeBlanch
CodeBlanch approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla
Copy link
Contributor

utpilla commented Nov 17, 2022

@chris-smith-zocdoc Please update your branch with the latest changes from main branch. Maintainers do not have access to update your branch.

@chris-smith-zocdoc
Copy link
Contributor Author

@utpilla done

@utpilla utpilla merged commit 23dbc39 into open-telemetry:main Nov 17, 2022
@chris-smith-zocdoc chris-smith-zocdoc deleted the cs_context branch November 28, 2022 14:14
@chris-smith-zocdoc
Copy link
Contributor Author

@utpilla is it possible to cut a release which includes this change?

@utpilla
Copy link
Contributor

utpilla commented Nov 28, 2022

@chris-smith-zocdoc Please follow the steps mentioned in the CONTRIBUTING doc to request a release: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package

@chris-smith-zocdoc chris-smith-zocdoc mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla left review comments

@CodeBlanch CodeBlanch CodeBlanch approved these changes

Assignees
No one assigned
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(AspNet.TelemetryHttpModule) Activity.Current not restored before all IIS LifeCycle events
3 participants
@chris-smith-zocdoc @CodeBlanch @utpilla