Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TelemetryHttpModule] Update OpenTelemetry.Api reference and changelog #665

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Sep 28, 2022

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@vishweshbankwar vishweshbankwar requested a review from a team September 28, 2022 02:32
@Kielek
Copy link
Contributor

Kielek commented Sep 28, 2022

Probably I have missed something, but what is a reason for the release? CHANGELOG.md is empty.

BTW consider to update reference to OTel.Api to 1.3.1 as 1.3.0 is unlisted.

@vishweshbankwar vishweshbankwar changed the title [TelemetryHttpModule] Update changelog [TelemetryHttpModule] Update OpenTelemetry.Api reference and changelog Sep 28, 2022
@vishweshbankwar
Copy link
Member Author

Probably I have missed something, but what is a reason for the release? CHANGELOG.md is empty.

BTW consider to update reference to OTel.Api to 1.3.1 as 1.3.0 is unlisted.

Good catch on Api reference. I have updated it. We keep the version for this one same as OpenTelemetry.Instrumentation.AspNet. That was the reason for empty changelog before, I had updated the version for instrumentation lib but missed this one.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #665 (92ff139) into main (79d7498) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files         173      173           
  Lines        5160     5160           
=======================================
  Hits         4005     4005           
  Misses       1155     1155           

@utpilla utpilla added the comp:instrumentation.aspnet.telemetryhttpmodule Things related to OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule label Sep 28, 2022
@utpilla utpilla merged commit 00a1de9 into open-telemetry:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnet.telemetryhttpmodule Things related to OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants