-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix null tags. #566
Fix null tags. #566
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Please reopen |
Please resolve the merge conflicts. |
Of course, have not seen that. |
…-contrib # Conflicts: # src/OpenTelemetry.Exporter.Stackdriver/Implementation/ActivityExtensions.cs # src/OpenTelemetry.Exporter.Stackdriver/StackdriverTraceExporter.cs # test/OpenTelemetry.Exporter.Stackdriver.Tests/StackdriverExporterTests.cs
Conflicts are solved. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 76.70% 77.76% +1.05%
==========================================
Files 170 170
Lines 5161 5163 +2
==========================================
+ Hits 3959 4015 +56
+ Misses 1202 1148 -54
|
Please fix the failing CI task as well. |
@SergeyKanzhelev Could you please review this PR? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I think it is a critical bug and it would be great if it can be merged asap |
@SebastianStehle Please add a CHANGELOG entry. After you have done that, if you would like a new version for the package released, please follow the steps mentioned here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package |
Fixes #565
Changes