Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null tags. #566

Merged
merged 10 commits into from
Sep 6, 2022
Merged

Fix null tags. #566

merged 10 commits into from
Sep 6, 2022

Conversation

SebastianStehle
Copy link
Contributor

Fixes #565

Changes

  • Convert null tags to correct attribute value.
  • Fix tests, which were not using the correct activities.
  • Fix an edge case where an invalid activity would throw exceptions in the exporter.

@SebastianStehle SebastianStehle requested a review from a team August 8, 2022 08:09
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SebastianStehle / name: Sebastian Stehle (a10890e)

@utpilla utpilla added the comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver label Aug 9, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 17, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 24, 2022
@SebastianStehle
Copy link
Contributor Author

Please reopen

@utpilla utpilla reopened this Aug 24, 2022
@utpilla
Copy link
Contributor

utpilla commented Aug 24, 2022

Please resolve the merge conflicts.

@SebastianStehle
Copy link
Contributor Author

Of course, have not seen that.

…-contrib

# Conflicts:
#	src/OpenTelemetry.Exporter.Stackdriver/Implementation/ActivityExtensions.cs
#	src/OpenTelemetry.Exporter.Stackdriver/StackdriverTraceExporter.cs
#	test/OpenTelemetry.Exporter.Stackdriver.Tests/StackdriverExporterTests.cs
@SebastianStehle
Copy link
Contributor Author

Conflicts are solved.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #566 (a976ccf) into main (bf01da1) will increase coverage by 1.05%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   76.70%   77.76%   +1.05%     
==========================================
  Files         170      170              
  Lines        5161     5163       +2     
==========================================
+ Hits         3959     4015      +56     
+ Misses       1202     1148      -54     
Impacted Files Coverage Δ
...r.Stackdriver/Implementation/ActivityExtensions.cs 71.05% <0.00%> (+71.05%) ⬆️
...y.Exporter.Stackdriver/StackdriverTraceExporter.cs 67.50% <100.00%> (+3.39%) ⬆️

@github-actions github-actions bot removed the Stale label Aug 25, 2022
@utpilla
Copy link
Contributor

utpilla commented Aug 25, 2022

Please fix the failing CI task as well.

@utpilla
Copy link
Contributor

utpilla commented Aug 25, 2022

@SergeyKanzhelev Could you please review this PR?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 2, 2022
@SebastianStehle
Copy link
Contributor Author

I think it is a critical bug and it would be great if it can be merged asap

@github-actions github-actions bot removed the Stale label Sep 3, 2022
@utpilla utpilla merged commit 0adee5a into open-telemetry:main Sep 6, 2022
@utpilla
Copy link
Contributor

utpilla commented Sep 6, 2022

@SebastianStehle Please add a CHANGELOG entry. After you have done that, if you would like a new version for the package released, please follow the steps mentioned here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null attributes not handled properly
5 participants