-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bugs in Runtime metrics #409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 155 155
Lines 4776 4776
=====================================
Misses 4776 4776
|
xiang17
changed the title
Fix existing bugs in Runtime metrics
Fix some bugs in Runtime metrics
Jun 8, 2022
reyang
reviewed
Jun 9, 2022
reyang
reviewed
Jun 9, 2022
reyang
approved these changes
Jun 9, 2022
alanwest
reviewed
Jun 10, 2022
alanwest
approved these changes
Jun 10, 2022
swetharavichandrancisco
pushed a commit
to swetharavichandrancisco/opentelemetry-dotnet-contrib
that referenced
this pull request
Jun 16, 2022
* Update instrument types, value types and units and some renames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383.
Changes
gc.fragmentation.ratio
, use ObservableGauge and change value from percentage to fraction in range of [0, 1]alloc.rate
togc.allocated.bytes
gc.committed
: use ObservableGaugeFor significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes