-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove contrib from Stackdriver #223
Remove contrib from Stackdriver #223
Conversation
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 79.14% 79.14%
=======================================
Files 97 97
Lines 2498 2498
=======================================
Hits 1977 1977
Misses 521 521 |
...y.Contrib.Exporter.Stackdriver.Tests/OpenTelemetry.Contrib.Exporter.Stackdriver.Tests.csproj
Outdated
Show resolved
Hide resolved
Can you please add a note into the changelog https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Contrib.Exporter.Stackdriver/CHANGELOG.md |
@@ -1,5 +1,10 @@ | |||
# Changelog | |||
|
|||
## Unreleased | |||
|
|||
* Renamed project to `OpenTelemetry.Exporter.Stackdriver` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets be a bit more specific here:
The nuget package will named `OpenTelemetry.Exporter.Stackdrive" going forward. Add link-to-new one (It'll be a deadlink now, but once we publish it'll be fixed). The old versions can still be found in nuget.org/link-to-old-package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ something like this which advices the users about the impact of this on them, and how to manage the impact.
* Remove contrib from Stackdriver
Towards #196
Note: This does not change the directory structure at all or the test project name or the namespaces.