Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contrib from Stackdriver #223

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Remove contrib from Stackdriver #223

merged 7 commits into from
Mar 17, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Mar 11, 2022

Towards #196

Note: This does not change the directory structure at all or the test project name or the namespaces.

@mic-max mic-max requested a review from a team March 11, 2022 00:28
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #223 (3869461) into main (51128b0) will not change coverage.
The diff coverage is n/a.

❗ Current head 3869461 differs from pull request most recent head db2860c. Consider uploading reports for the commit db2860c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files          97       97           
  Lines        2498     2498           
=======================================
  Hits         1977     1977           
  Misses        521      521           

@SergeyKanzhelev
Copy link
Member

Can you please add a note into the changelog https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Contrib.Exporter.Stackdriver/CHANGELOG.md

@@ -1,5 +1,10 @@
# Changelog

## Unreleased

* Renamed project to `OpenTelemetry.Exporter.Stackdriver`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets be a bit more specific here:
The nuget package will named `OpenTelemetry.Exporter.Stackdrive" going forward. Add link-to-new one (It'll be a deadlink now, but once we publish it'll be fixed). The old versions can still be found in nuget.org/link-to-old-package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ something like this which advices the users about the impact of this on them, and how to manage the impact.

@mic-max mic-max requested a review from cijothomas March 16, 2022 23:15
@utpilla utpilla merged commit cd94736 into open-telemetry:main Mar 17, 2022
@mic-max mic-max deleted the rename-contrib-stackdriver branch March 17, 2022 05:09
swetharavichandrancisco pushed a commit to swetharavichandrancisco/opentelemetry-dotnet-contrib that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants