-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Allow skipping paths in sanity check script #2060
[repo] Allow skipping paths in sanity check script #2060
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
+ Coverage 73.91% 77.62% +3.70%
==========================================
Files 267 320 +53
Lines 9615 12579 +2964
==========================================
+ Hits 7107 9764 +2657
- Misses 2508 2815 +307 Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -8,12 +8,21 @@ | |||
CRLF = b'\r\n' | |||
LF = b'\n' | |||
|
|||
# Add paths to exclude from sanity checks here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Add a comment saying these are done to mainly for auto-generated code from the checks, until code generation itself can be fixed, if at all possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Don't think we need more sophisticated mechanisms for now.
Thank you!
Split from #1944 and #2040
Design discussion:
#2040 (comment)
Changes
Changes the sanitycheck python script to exclude paths from the checks. For a simple version, the directories to exclude are hard coded. Let me know if you think this is a good start or if you want to make it more dynamic (e.g., passed via GH actions)
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changesCC @cijothomas