-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Instana] nullable support #1928
[Exporter.Instana] nullable support #1928
Conversation
# Conflicts: # src/OpenTelemetry.Exporter.Instana/OpenTelemetry.Exporter.Instana.csproj
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1928 +/- ##
==========================================
- Coverage 73.91% 71.42% -2.49%
==========================================
Files 267 15 -252
Lines 9615 553 -9062
==========================================
- Hits 7107 395 -6712
+ Misses 2508 158 -2350
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Public contract LTGM.
I have fixes ignoring warnings.
Other part of code I left to your judgement. Merging.
Thanks for contributing to nullability task.
Towards #894.