Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Instana] nullable support #1928

Merged

Conversation

zivaninstana
Copy link
Contributor

Towards #894.

# Conflicts:
#	src/OpenTelemetry.Exporter.Instana/OpenTelemetry.Exporter.Instana.csproj
@zivaninstana zivaninstana requested a review from a team June 25, 2024 09:42
@github-actions github-actions bot added the comp:exporter.instana Things related to OpenTelemetry.Instrumentation.Instana label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 86.39053% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.42%. Comparing base (71655ce) to head (18018eb).
Report is 345 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
- Coverage   73.91%   71.42%   -2.49%     
==========================================
  Files         267       15     -252     
  Lines        9615      553    -9062     
==========================================
- Hits         7107      395    -6712     
+ Misses       2508      158    -2350     
Flag Coverage Δ
unittests-Exporter.Instana 71.42% <86.39%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...try.Exporter.Instana/Implementation/InstanaSpan.cs 100.00% <100.00%> (ø)
...Instana/Implementation/InstanaSpanTransformInfo.cs 100.00% <100.00%> (ø)
...Implementation/Processors/ActivityProcessorBase.cs 42.85% <100.00%> (-50.00%) ⬇️
...mplementation/Processors/ErrorActivityProcessor.cs 100.00% <100.00%> (ø)
...plementation/Processors/EventsActivityProcessor.cs 93.75% <100.00%> (ø)
.../OpenTelemetry.Exporter.Instana/InstanaExporter.cs 78.37% <92.85%> (ø)
...Implementation/Processors/TagsActivityProcessor.cs 91.30% <75.00%> (-8.70%) ⬇️
...er.Instana/Implementation/InstanaSpanSerializer.cs 90.37% <66.66%> (-3.43%) ⬇️
...metry.Exporter.Instana/Implementation/Transport.cs 0.00% <0.00%> (ø)
...lementation/Processors/DefaultActivityProcessor.cs 59.18% <37.50%> (+1.73%) ⬆️

... and 253 files with indirect coverage changes

@Kielek Kielek changed the title OpenTelemetry.Exporter.Instana nullable support [Exporter.Instana] nullable support Jun 26, 2024
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public contract LTGM.
I have fixes ignoring warnings.
Other part of code I left to your judgement. Merging.

Thanks for contributing to nullability task.

@Kielek Kielek merged commit 39526e6 into open-telemetry:main Jun 26, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.instana Things related to OpenTelemetry.Instrumentation.Instana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants