Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] ImplicitUsings - enable globally #1927

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 25, 2024

Changes

Finalize #1923

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:persistentstorage.abstractions Things related to OpenTelemetry.PersistentStorage.Abstractions comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.azure Things related to OpenTelemetry.Resources.Azure comp:resources.container Things related to OpenTelemetry.Resources.Container comp:resources.gcp Things related to OpenTelemetry.Resources.Gcp comp:resources.host Things related to OpenTelemetry.Resources.Host comp:resources.process Things related to OpenTelemetry.Resources.Process comp:resources.processruntime Things related to OpenTelemetry.Resources.ProcessRuntime comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS perf Performance related labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.11%. Comparing base (71655ce) to head (5e01f2e).
Report is 344 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1927      +/-   ##
==========================================
- Coverage   73.91%   71.11%   -2.81%     
==========================================
  Files         267      299      +32     
  Lines        9615    11541    +1926     
==========================================
+ Hits         7107     8207    +1100     
- Misses       2508     3334     +826     
Flag Coverage Δ
unittests-Exporter.Geneva 53.20% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 68.22% <ø> (?)
unittests-Exporter.OneCollector 91.29% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 80.59% <ø> (?)
unittests-Instrumentation.AWSLambda 87.96% <ø> (?)
unittests-Instrumentation.AspNet 74.85% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 81.79% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 74.53% <ø> (?)
unittests-Resources.Azure 78.35% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 51.16% <ø> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Resources.ProcessRuntime 82.35% <ø> (?)
unittests-Sampler.AWS 87.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...umentation.AWS/Implementation/AWSMessagingUtils.cs 100.00% <ø> (ø)
...AWS/Implementation/AWSPropagatorPipelineHandler.cs 80.95% <ø> (ø)
...rumentation.AWS/Implementation/AWSServiceHelper.cs 100.00% <ø> (ø)
...strumentation.AWS/Implementation/AWSServiceType.cs 66.66% <ø> (ø)
...AWS/Implementation/AWSTracingPipelineCustomizer.cs 90.90% <ø> (+3.40%) ⬆️
...on.AWS/Implementation/AWSTracingPipelineHandler.cs 74.74% <ø> (-13.01%) ⬇️
...tion.AWS/Implementation/SnsRequestContextHelper.cs 81.81% <ø> (-13.19%) ⬇️
...tion.AWS/Implementation/SqsRequestContextHelper.cs 81.81% <ø> (-13.19%) ⬇️
...emetry.Instrumentation.AWS/Implementation/Utils.cs 75.00% <ø> (ø)
...rumentation.AWS/TracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
... and 68 more

... and 237 files with indirect coverage changes

@Kielek Kielek merged commit b842339 into open-telemetry:main Jun 26, 2024
266 of 267 checks passed
@Kielek Kielek deleted the implicitusings3 branch June 26, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB comp:exporter.instana Things related to OpenTelemetry.Instrumentation.Instana comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:extensions Things related to OpenTelemetry.Extensions comp:instrumentation.aspnet.telemetryhttpmodule Things related to OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.eventcounters Things related to OpenTelemetry.Instrumentation.EventCounters comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:persistentstorage.abstractions Things related to OpenTelemetry.PersistentStorage.Abstractions comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.azure Things related to OpenTelemetry.Resources.Azure comp:resources.container Things related to OpenTelemetry.Resources.Container comp:resources.gcp Things related to OpenTelemetry.Resources.Gcp comp:resources.host Things related to OpenTelemetry.Resources.Host comp:resources.process Things related to OpenTelemetry.Resources.Process comp:resources.processruntime Things related to OpenTelemetry.Resources.ProcessRuntime comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS documentation Improvements or additions to documentation infra Infra work - CI/CD, code coverage, linters perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.