-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onecollector] Add LoggerProviderBuilder registration extension #1876
Merged
CodeBlanch
merged 6 commits into
open-telemetry:main
from
CodeBlanch:onecollectorexporter-loggerproviderbuilder-extension
Jun 11, 2024
Merged
[onecollector] Add LoggerProviderBuilder registration extension #1876
CodeBlanch
merged 6 commits into
open-telemetry:main
from
CodeBlanch:onecollectorexporter-loggerproviderbuilder-extension
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
added
the
comp:exporter.onecollector
Things related to OpenTelemetry.Exporter.OneCollector
label
Jun 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
===========================================
+ Coverage 73.91% 91.51% +17.59%
===========================================
Files 267 26 -241
Lines 9615 1013 -8602
===========================================
- Hits 7107 927 -6180
+ Misses 2508 86 -2422
Flags with carried forward coverage won't be shown. Click here to find out more.
|
reyang
approved these changes
Jun 10, 2024
cijothomas
reviewed
Jun 10, 2024
src/OpenTelemetry.Exporter.OneCollector/Logs/OneCollectorLoggerProviderBuilderExtensions.cs
Show resolved
Hide resolved
vishweshbankwar
approved these changes
Jun 11, 2024
CodeBlanch
deleted the
onecollectorexporter-loggerproviderbuilder-extension
branch
June 11, 2024 00:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LoggerProviderBuilder.AddOneCollectorExporter
to supportLoggerProviderBuilder
patterns being introduced in OTel 1.9.0.Checklist
CHANGELOG.md
updated for non-trivial changes