Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onecollector] Add LoggerProviderBuilder registration extension #1876

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jun 10, 2024

Changes

  • Adds LoggerProviderBuilder.AddOneCollectorExporter to support LoggerProviderBuilder patterns being introduced in OTel 1.9.0.

Checklist

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit tests updated
  • Changes in public API reviewed

@CodeBlanch CodeBlanch added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Jun 10, 2024
@CodeBlanch CodeBlanch requested a review from a team June 10, 2024 21:03
@github-actions github-actions bot requested a review from reyang June 10, 2024 21:03
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.51%. Comparing base (71655ce) to head (f1f4a4c).
Report is 294 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1876       +/-   ##
===========================================
+ Coverage   73.91%   91.51%   +17.59%     
===========================================
  Files         267       26      -241     
  Lines        9615     1013     -8602     
===========================================
- Hits         7107      927     -6180     
+ Misses       2508       86     -2422     
Flag Coverage Δ
unittests-Exporter.OneCollector 91.51% <94.73%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rialization/LogRecordCommonSchemaJsonSerializer.cs 98.34% <ø> (-0.83%) ⬇️
...ctor/Logs/OneCollectorLogExportProcessorBuilder.cs 96.73% <100.00%> (+28.99%) ⬆️
...neCollectorOpenTelemetryLoggerOptionsExtensions.cs 76.47% <100.00%> (-1.31%) ⬇️
...eCollector/OneCollectorExporterTransportOptions.cs 76.47% <100.00%> (+5.04%) ⬆️
...ogs/OneCollectorLoggerProviderBuilderExtensions.cs 81.48% <81.48%> (ø)

... and 253 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 1b3dd94 into open-telemetry:main Jun 11, 2024
63 checks passed
@CodeBlanch CodeBlanch deleted the onecollectorexporter-loggerproviderbuilder-extension branch June 11, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants