Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup shared references #1595

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Feb 28, 2024

Fixes #1430 (comment)

Changes

Drop most of the Shared properties.
The only exception if for IncludeSharedSpanHelper. There are two independent copies of similar files. I have a plan to solve it in follow up pr.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.84%. Comparing base (71655ce) to head (7c2061b).
Report is 154 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1595      +/-   ##
==========================================
- Coverage   73.91%   72.84%   -1.07%     
==========================================
  Files         267      258       -9     
  Lines        9615     9392     -223     
==========================================
- Hits         7107     6842     -265     
- Misses       2508     2550      +42     
Flag Coverage Δ
unittests-Exporter.Geneva 58.17% <ø> (?)
unittests-Exporter.OneCollector 89.46% <ø> (?)
unittests-Extensions 82.75% <ø> (?)
unittests-Instrumentation.AspNet 75.96% <ø> (?)
unittests-Instrumentation.EventCounters 75.92% <ø> (?)
unittests-Instrumentation.Owin 85.71% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 58.80% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 40.00% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 79.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 208 files with indirect coverage changes

Copy link
Contributor

@Havret Havret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

@iskiselev iskiselev removed their assignment Feb 28, 2024
@Kielek Kielek merged commit 41ac9f4 into open-telemetry:main Feb 28, 2024
112 of 113 checks passed
@Kielek Kielek deleted the cleanup-shared-references branch February 28, 2024 19:36
@Kielek Kielek mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.