Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCF: Added TelemetryContractBehaviorAttribute to support programmatic configuration #153

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

CodeBlanch
Copy link
Member

No description provided.

@CodeBlanch CodeBlanch requested a review from a team September 10, 2021 20:47
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #153 (dded745) into main (b907e05) will decrease coverage by 0.19%.
The diff coverage is 66.66%.

❗ Current head dded745 differs from pull request most recent head acfe7cc. Consider uploading reports for the commit acfe7cc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   79.37%   79.17%   -0.20%     
==========================================
  Files          67       68       +1     
  Lines        1789     1796       +7     
==========================================
+ Hits         1420     1422       +2     
- Misses        369      374       +5     
Impacted Files Coverage Δ
...entation.Wcf/TelemetryContractBehaviorAttribute.cs 0.00% <0.00%> (ø)
...b.Instrumentation.Wcf/TelemetryEndpointBehavior.cs 92.85% <100.00%> (+1.19%) ⬆️

@CodeBlanch
Copy link
Member Author

@mconnew If you have time would you mind reviewing this for me?

@mconnew
Copy link

mconnew commented Sep 10, 2021

@CodeBlanch, it looks like all you are intending is to create an attribute that can be applied to the ServiceContract instead of adding to the ChannelFactory or ServiceHost, if so, then this looks correct.

@CodeBlanch
Copy link
Member Author

@mconnew

It looks like all you are intending is to create an attribute that can be applied to the ServiceContract instead of adding to the ChannelFactory or ServiceHost, if so, then this looks correct.

That's what I was thinking, yes.

@CodeBlanch CodeBlanch closed this Sep 11, 2021
@CodeBlanch CodeBlanch reopened this Sep 11, 2021
@CodeBlanch CodeBlanch merged commit 844a3cf into open-telemetry:main Sep 13, 2021
@CodeBlanch CodeBlanch deleted the wcf-programmatic-config branch September 13, 2021 04:47
@CodeBlanch
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants