-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Dedicated workflows for Instrumentation.Process & Exporter.OneCollector #1355
[repo] Dedicated workflows for Instrumentation.Process & Exporter.OneCollector #1355
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
+ Coverage 73.91% 74.14% +0.22%
==========================================
Files 267 258 -9
Lines 9615 9472 -143
==========================================
- Hits 7107 7023 -84
+ Misses 2508 2449 -59
Flags with carried forward coverage won't be shown. Click here to find out more. |
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkPkgVer)" Condition="'$(IsTestProject)' == 'true'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up PR - probably we can do the same with xunit, dotnet-xunit and xunit-visualstudio-runner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to that. But I didn't here because I thought I saw one project using MSTest (not xunit). Personally I am OK with component owners using a different framework if they want, no reason in my mind that they MUST use xunit
. But we could simplify it down by using a property like <XUnitEnabled>true</XUnitEnabled>
and then use that to add in whatever references we need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go with opt-out for XUnitEnabled for all tests packages as major (all?) of our packages are based on this.
BTW I cannot find the MSTest reference in this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looked, I couldn't find it either. Maybe I imagined it 😄 Anyway opened this: #1363
…opentelemetry-dotnet-contrib into repo-ci-improvements
Relates to #1348
Relates to #1347
Changes
Cleanup:
Microsoft.NET.Test.Sdk
reference to test projects via common.nonprod.props. Removed direct references from test projects.coverlet.collector
where it was being referenced. We're not using it.Microsoft.CodeCoverage
reference fromcommon.props
. Not sure why it was even there. Tests projects where it is needed will now get it transitively viaMicrosoft.NET.Test.Sdk
.Condition="$([MSBuild]::IsOsPlatform('Windows'))"
fromxunit.runner.visualstudio
where it was defined in test projects. That prevents tests from running on linux in CI.dotnet-coverage
global tool instead of the powershell script +reportgenerator
global tool.Improvements:
Maybe Improvements: