-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneCollectorExporter] Failed transmission callback #1309
Merged
CodeBlanch
merged 9 commits into
open-telemetry:main
from
CodeBlanch:onecollector-failuretransmissions
Aug 24, 2023
Merged
[OneCollectorExporter] Failed transmission callback #1309
CodeBlanch
merged 9 commits into
open-telemetry:main
from
CodeBlanch:onecollector-failuretransmissions
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iving failed transmissions.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
==========================================
+ Coverage 74.27% 74.53% +0.25%
==========================================
Files 262 262
Lines 9490 9524 +34
==========================================
+ Hits 7049 7099 +50
+ Misses 2441 2425 -16
|
reyang
reviewed
Aug 16, 2023
src/OpenTelemetry.Exporter.OneCollector/OneCollectorExporter.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Aug 16, 2023
...enTelemetry.Exporter.OneCollector/OneCollectorExporterPayloadTransmittedCallbackArguments.cs
Outdated
Show resolved
Hide resolved
Kielek
added
the
comp:exporter.onecollector
Things related to OpenTelemetry.Exporter.OneCollector
label
Aug 21, 2023
reyang
reviewed
Aug 23, 2023
reyang
reviewed
Aug 23, 2023
...enTelemetry.Exporter.OneCollector/OneCollectorExporterPayloadTransmittedCallbackArguments.cs
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Aug 24, 2023
utpilla
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TODOs
CHANGELOG.md
updated for non-trivial changes