Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample.AWS.Tests - nullable #1304

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Aug 11, 2023

Towards #894

Changes

Sample.AWS.Tests - nullable
Opportunistic semi-auto code cleanup

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek added the comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS label Aug 11, 2023
@Kielek Kielek marked this pull request as ready for review August 11, 2023 08:50
@Kielek Kielek requested a review from a team August 11, 2023 08:50
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1304 (84a68a1) into main (75d7622) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 84a68a1 differs from pull request most recent head 7b145c3. Consider uploading reports for the commit 7b145c3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
+ Coverage   74.49%   74.50%   +0.01%     
==========================================
  Files         266      266              
  Lines        9659     9657       -2     
==========================================
  Hits         7195     7195              
+ Misses       2464     2462       -2     
Files Changed Coverage
...lemetry.Sampler.AWS/AWSXRayRemoteSamplerBuilder.cs 0.00%
...c/OpenTelemetry.Sampler.AWS/SamplingRuleApplier.cs 100.00%

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 25, 2023
@Kielek Kielek removed the Stale label Aug 28, 2023
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kielek Kielek merged commit ae05c91 into open-telemetry:main Sep 5, 2023
@Kielek Kielek deleted the nullable-aws-sampler-tests branch September 5, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants