Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.AWSLambda] Enable nullable #1295

Merged
merged 21 commits into from
Aug 10, 2023
Merged

[Instrumentation.AWSLambda] Enable nullable #1295

merged 21 commits into from
Aug 10, 2023

Conversation

rypdal
Copy link
Contributor

@rypdal rypdal commented Aug 7, 2023 •
edited by Kielek
Loading

Towards #894

Changes

Enabled Nullable for OpenTelemetry.Instrumentation.AWSLambda projects and it's tests. Code has been adapted accordingly.

@rypdal rypdal requested a review from a team August 7, 2023 14:55
@github-actions github-actions bot requested a review from Oberon00 August 7, 2023 14:55
@utpilla utpilla added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #1295 (ecc6330) into main (c49d0e8) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head ecc6330 differs from pull request most recent head df55a4e. Consider uploading reports for the commit df55a4e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   74.23%   74.14%   -0.10%     
==========================================
  Files         256      256              
  Lines        9345     9347       +2     
==========================================
- Hits         6937     6930       -7     
- Misses       2408     2417       +9
Files Changed Coverage Δ
...ation.AWSLambda/Implementation/CommonExtensions.cs 80.00% <ø> (ø)
...ation.AWSLambda/TracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...etry.Instrumentation.AWSLambda/AWSLambdaWrapper.cs 94.64% <100.00%> (ø)
...ion.AWSLambda/Implementation/AWSLambdaHttpUtils.cs 100.00% <100.00%> (ø)
...ntation.AWSLambda/Implementation/AWSLambdaUtils.cs 81.57% <100.00%> (ø)
...tion.AWSLambda/Implementation/AWSMessagingUtils.cs 74.50% <100.00%> (ø)

... and 4 files with indirect coverage changes

Oberon00
Oberon00 reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a CHANGELOG entry.

src/OpenTelemetry.Instrumentation.AWSLambda/AWSLambdaWrapper.cs Outdated Show resolved Hide resolved
rypdal and others added 2 commits August 8, 2023 16:32
@rypdal @Oberon00
Update test/OpenTelemetry.Instrumentation.AWSLambda.Tests/Implementat…
fce5a66 
…ion/AWSMessagingUtilsTests.cs


open-telemetry#894: review suggestion

Co-authored-by: Christian Neumüller <[email protected]>
@rypdal
open-telemetry#894: made ILambdaContext non-nullable (for AWS lambda …
edd3e9d 
…functions it must be always available)
Oberon00
Oberon00 reviewed Aug 9, 2023
View reviewed changes
src/OpenTelemetry.Instrumentation.AWSLambda/.publicApi/netstandard2.0/PublicAPI.Shipped.txt Outdated Show resolved Hide resolved
src/OpenTelemetry.Instrumentation.AWSLambda/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt Show resolved Hide resolved
src/OpenTelemetry.Instrumentation.AWSLambda/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt Show resolved Hide resolved
src/OpenTelemetry.Instrumentation.AWSLambda/AWSLambdaWrapper.cs Show resolved Hide resolved
src/OpenTelemetry.Instrumentation.AWSLambda/Implementation/AWSLambdaHttpUtils.cs Show resolved Hide resolved
test/OpenTelemetry.Instrumentation.AWSLambda.Tests/AWSLambdaWrapperTests.cs Outdated Show resolved Hide resolved
test/OpenTelemetry.Instrumentation.AWSLambda.Tests/Implementation/AWSLambdaHttpUtilsTests.cs Outdated Show resolved Hide resolved
@Kielek Kielek requested a review from Oberon00 August 10, 2023 04:59
Oberon00
Oberon00 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Kielek
Kielek approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Kielek Kielek merged commit 01378f4 into open-telemetry:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

Assignees

@Oberon00 Oberon00

@rypdal rypdal

Labels
comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rypdal @Oberon00 @Kielek @utpilla