[Instrumentation.AWSLambda] Update dependency to OpenTelemetry.Extensions.AWS #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
added
the
comp:instrumentation.awslambda
rypdal
reviewed
Aug 2, 2023
| .CreateEmpty() | ||
| .AddTelemetrySdk() | ||
| .AddAttributes(AWSLambdaResourceDetector.Detect())); | ||
| builder.ConfigureResource(x => x.AddDetector(new AWSLambdaResourceDetector())); |
There was a problem hiding this comment.
Is this changed triggered by OpenTelemetry.Extensions.AWS update ?
There was a problem hiding this comment.
ConfigureResource is part of the API from newer OTel SDK package.
Old version should still work, but if your user adjust resources manually it should keep changes in place.
Previous version was overriding everything.
There was a problem hiding this comment.
I think this is a great change. So far we were not able to actually use the resource functionality since we also needed some custom attributes.
utpilla
reviewed
Aug 2, 2023
src/OpenTelemetry.Instrumentation.AWSLambda/Implementation/AWSLambdaResourceDetector.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Aug 2, 2023
1 task
utpilla
approved these changes
Aug 3, 2023
rypdal
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1268
Changes
Update dependency to OpenTelemetry.Extensions.AWS
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed