[Instrumentation.MySqlData] Nullable #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moonheart, could you please check? |
|
This LGTM 👍 |
utpilla
added
the
comp:instrumentation.mysqldata
utpilla
approved these changes
Mar 20, 2023
utpilla
reviewed
Mar 20, 2023
| @@ -41,7 +41,7 @@ public static class TracerProviderBuilderExtensions | |||
| /// <returns>The instance of <see cref="TracerProviderBuilder"/> to chain the calls.</returns> | |||
| public static TracerProviderBuilder AddMySqlDataInstrumentation( | |||
| this TracerProviderBuilder builder, | |||
| Action<MySqlDataInstrumentationOptions> configure) | |||
| Action<MySqlDataInstrumentationOptions>? configure) | |||
There was a problem hiding this comment.
We should probably not put ? to stay consistent with other instrumentation libraries.
Look at this for reference: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/TracerProviderBuilderExtensions.cs#L59-L71
There was a problem hiding this comment.
Ah okay. Thanks for sharing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #894.
Changes
[Instrumentation.MySqlData] Nullable.
Part of shared files also updated.
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed