Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform CI checks for auto-generated semantic conventions #2068

Open
joaopgrassi opened this issue Sep 13, 2024 · 0 comments
Open

Perform CI checks for auto-generated semantic conventions #2068

joaopgrassi opened this issue Sep 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@joaopgrassi
Copy link
Member

Component

OpenTelemetry.SemanticConventions

Is your feature request related to a problem?

During #2040 we identified that it would be great if we had CI checks that guaranteed:

  • That the versions in generate.ps1 and generated.sh` match
  • That no manual changes are made to the auto-generated semconv files

What is the expected behavior?

Discrepancies in the generate scripts AND manual changes on semconv files should be caught during CI checks.

Which alternative solutions or features have you considered?

Adding CI checks.

Additional context

See context in this thread: #2040 (comment)
@joaopgrassi joaopgrassi added the enhancement New feature or request label Sep 13, 2024
@joaopgrassi joaopgrassi mentioned this issue Sep 13, 2024
Merged
4 tasks
joaopgrassi added a commit to dynatrace-oss-contrib/opentelemetry-dotnet-contrib that referenced this issue Sep 13, 2024
@joaopgrassi
Remove checks for now
4e81c53 
Will be done in a follow up
open-telemetry#2068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joaopgrassi