-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Update BaggageActivityProcessor to use baggage key predicate #1816
[Extensions] Update BaggageActivityProcessor to use baggage key predicate #1816
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1816 +/- ##
===========================================
+ Coverage 73.91% 85.71% +11.79%
===========================================
Files 267 8 -259
Lines 9615 140 -9475
===========================================
- Hits 7107 120 -6987
+ Misses 2508 20 -2488
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…-contrib into mike/baggage-predicate
…elemetry-dotnet-contrib into mike/baggage-predicate
Ping @open-telemetry/dotnet-contrib-approvers @open-telemetry/dotnet-contrib-maintainers - please can you take a look? |
src/OpenTelemetry.Extensions/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Extensions/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Extensions/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Thanks for the feedback @CodeBlanch - I've made some updates, please take another look. |
test/OpenTelemetry.Extensions.Tests/Trace/BaggageActivityProcessorTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Extensions.Tests/Trace/BaggageActivityProcessorTests.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Extensions/Internal/OpenTelemetryExtensionsEventSource.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Extensions.Tests/Trace/BaggageActivityProcessorTests.cs
Show resolved
Hide resolved
…elemetry-dotnet-contrib into mike/baggage-predicate
…-contrib into mike/baggage-predicate # Conflicts: # src/OpenTelemetry.Extensions/CHANGELOG.md
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am generally not in favor of allowing arbitrary user code executions (see #1816 (comment)), but given there is an existing precedent in this component, not a blocker.
@MikeGoldsmith, could you please merge main branch to PR branch (or allow us to do this)? @CodeBlanch, do you have any other comments? |
@Kielek updated again, let me know if you need anything else. |
Can you fix the CI failures? Looks like some minor import statements causing CI to fail. |
Yeah, sure. I wasn't sure if they were intermittent / unrelated failures as they only occurred in the merge from main commits. I'll fix up the PR tomorrow. |
@MikeGoldsmith, it is the reason #1927 (or one of the previous PR for the same topic), unfortunately needs to be manually adjusted for all existing PRs. EDIT: Isee that you are contirbuting from corporate fork. If you could do from your personal, you can enable Allow maintainers to modify PR/brach. Then we can push trivial fixes/merges there without asking you. |
@Kielek @cijothomas removed the unused using statements and CI is passing now - thanks for your help 😄 |
…cate (open-telemetry#1816) Co-authored-by: Piotr Kiełkowicz <[email protected]> Co-authored-by: Cijo Thomas <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]>
Fixes #1695
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes