PR feedback - Fix CS8618

open-telemetry · Jun 26, 2024 · 18018eb · 18018eb
1 parent 65db532
commit 18018eb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/OpenTelemetry.Exporter.Instana/Implementation/Processors/ActivityProcessorBase.cs b/src/OpenTelemetry.Exporter.Instana/Implementation/Processors/ActivityProcessorBase.cs
@@ -7,9 +7,7 @@ namespace OpenTelemetry.Exporter.Instana.Implementation.Processors;
 
 internal abstract class ActivityProcessorBase : IActivityProcessor
 {
-#pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.
-    public IActivityProcessor NextProcessor { get; set; }
-#pragma warning restore CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.
+    public IActivityProcessor? NextProcessor { get; set; }
 
     public virtual async Task ProcessAsync(Activity activity, InstanaSpan instanaSpan)
     {

diff --git a/src/OpenTelemetry.Exporter.Instana/Implementation/Processors/IActivityProcessor.cs b/src/OpenTelemetry.Exporter.Instana/Implementation/Processors/IActivityProcessor.cs
@@ -5,7 +5,7 @@ namespace OpenTelemetry.Exporter.Instana.Implementation.Processors;
 
 internal interface IActivityProcessor
 {
-    IActivityProcessor NextProcessor { get; set; }
+    IActivityProcessor? NextProcessor { get; set; }
 
     Task ProcessAsync(System.Diagnostics.Activity activity, InstanaSpan instanaSpan);
 }
diff --git a/src/OpenTelemetry.Exporter.Instana/InstanaExporter.cs b/src/OpenTelemetry.Exporter.Instana/InstanaExporter.cs
@@ -59,7 +59,7 @@ public override ExportResult Export(in Batch<Activity> batch)
         From from = new From();
         if (this.instanaExporterHelper.IsWindows())
         {
-            from = new From() { E = Process.GetCurrentProcess().Id.ToString(CultureInfo.InvariantCulture) };
+            from = new From { E = Process.GetCurrentProcess().Id.ToString(CultureInfo.InvariantCulture) };
         }
 
         string serviceName = this.ExtractServiceName(ref from);