-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] + [paymentservice] - update JS SDKs #853
Conversation
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
I need to update docs for this as well since the instrumentation code has changed for both services. I will get to that in the next day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a comment, but not a blocker
@puckpuck, you mean transform processor? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I got rid of these printouts when starting frontend in docker:
frontend | Accessing resource attributes before async attributes settled
frontend | Process is not running on K8S [Error: ENOENT: no such file or directory, access '/var/run/secrets/kubernetes.io/serviceaccount/token'] {
frontend | errno: -2,
frontend | code: 'ENOENT',
frontend | syscall: 'access',
frontend | path: '/var/run/secrets/kubernetes.io/serviceaccount/token'
frontend | }
frontend | Dropped 277266 spans because maxQueueSize reached
frontend | Dropped 38851 spans because maxQueueSize reached
frontend | npm notice
frontend | npm notice New minor version of npm available! 9.5.1 -> 9.6.5
frontend | npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
frontend | npm notice Run `npm install -g [email protected]` to update!
frontend | npm notice
* update JS SDKs Signed-off-by: Pierre Tessier <[email protected]> * only use instrumentation-fs when part of a trace Signed-off-by: Pierre Tessier <[email protected]> * update js SDKS Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]>
* update JS SDKs Signed-off-by: Pierre Tessier <[email protected]> * only use instrumentation-fs when part of a trace Signed-off-by: Pierre Tessier <[email protected]> * update js SDKS Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]>
Changes
Fixes: #826
Updates the JS SDKs to the latest. Allows us to remove the filter processor in the collector. This change also configures the
instrumentation-fs
library to only instrument calls when part of another trace. This was required because that library would generate hundreds/thousands of single-span traces on startup.Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.