Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update for mac m2 #764

Merged
merged 3 commits into from
Mar 1, 2023
Merged

[chore] update for mac m2 #764

merged 3 commits into from
Mar 1, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Feb 28, 2023

Changes

Minor updates to work with Mac M2 architectures.

  • adservice/AdService.java - IntelliJ gave an error without the package prefix.
  • emailservice/Gemfile.lock - Add arm64-darwin-22
  • recommendationservice/requirements.txt - grpcio update required to work with M2 [ref]
  • CHANGELOG.md updated to document new feature additions

@puckpuck puckpuck requested a review from a team February 28, 2023 04:38
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine, didn't notice any change on M1.

@cartersocha
Copy link
Contributor

Changelog please!

Signed-off-by: Pierre Tessier <[email protected]>
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@puckpuck puckpuck merged commit 8653756 into open-telemetry:main Mar 1, 2023
@puckpuck puckpuck deleted the work_with_mac_m2 branch March 2, 2023 01:59
styblope pushed a commit to instana/opentelemetry-demo that referenced this pull request Mar 12, 2023
* update for mac m2

* update for mac m2

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
mat-rumian pushed a commit to SumoLogic/opentelemetry-demo that referenced this pull request Mar 20, 2023
* update for mac m2

* update for mac m2

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
* update for mac m2

* update for mac m2

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* update for mac m2

* update for mac m2

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants