Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add healthcheck to featureflagservice #661

Merged
merged 10 commits into from
Jan 19, 2023
Merged

Add healthcheck to featureflagservice #661

merged 10 commits into from
Jan 19, 2023

Conversation

cedricziel
Copy link
Contributor

@cedricziel cedricziel commented Dec 27, 2022 •
edited
Loading

Changes

In order to assess the health of this central service, compose should perform a check on the service.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@cedricziel
Add healthcheck to featureflagservice
18d4c3c 
In order to assess the health of this central service, compose should perform a check on the service.
@cedricziel cedricziel requested a review from a team December 27, 2022 09:37
@mic-max
Copy link
Contributor

mic-max commented Dec 27, 2022

I believe we have decided on monitoring the health using Kubernetes and on not supporting doing through docker like your proposal.

@cedricziel
Copy link
Contributor Author

Why is that? If a certain service fails in the docker compose scenario, how do you know (other than fallout)?

Does that mean the primary intention of this project is to be run on k8s? Then we should probably remove the docker compose file.

julianocosta89
julianocosta89 approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like the addition.
There is a discussion going on that may change this though.
@cedricziel please feel free to add your insights in here: #635

@cedricziel
Copy link
Contributor Author

@julianocosta89 thanks for raising awareness!

@puckpuck puckpuck added the helm-update-required Requires an update to the Helm chart when released label Jan 4, 2023
@julianocosta89
Copy link
Member

@puckpuck should we do something regarding helm in this one?
Otherwise, I think we are good to merge this one

@puckpuck
Copy link
Contributor

We don't need to touch Helm for this.

@puckpuck puckpuck merged commit 122b104 into open-telemetry:main Jan 19, 2023
mat-rumian added a commit to SumoLogic/opentelemetry-demo that referenced this pull request Feb 20, 2023
@mat-rumian @joshleecreates
@svrnm @julianocosta89 @cartersocha @pichlermarc @cedricziel @brettmc @jlawrie @austinlparker @jack-berg @xoscar @puckpuck @pbrzoska-sumo @AbhiPrasad @chalin @JaredTan95 @codeboten @gouthamve @cijothomas
Upstream update latest (#5)
06b7e68 
* Fixes open-telemetry#696, Downgrades OTP (open-telemetry#698)

* Use different base images for frauddetectionservice (open-telemetry#691)

* Use different docker base images for frauddetection service

Signed-off-by: svrnm <[email protected]>

* Add entry in CHANGELOG

Signed-off-by: svrnm <[email protected]>

* update changelog

Signed-off-by: svrnm <[email protected]>

* Remove extra blank line

Signed-off-by: svrnm <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Carter Socha <[email protected]>

* fix(paymentservice): respect temporality env var (open-telemetry#693)

* fix(paymentservice): update dependencies so that temporality env var is respected

* fix(changelog): add changelog entry

* Add healthcheck to featureflagservice (open-telemetry#661)

* Add healthcheck to featureflagservice

In order to assess the health of this central service, compose should perform a check on the service.

* Add changelog entry

Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Carter Socha <[email protected]>

* bot is broken (open-telemetry#699)

Co-authored-by: Juliano Costa <[email protected]>

* Fix link to the docs (open-telemetry#701)

* reduce quoteservice spans (open-telemetry#702)

* fixing container name nit - quote service (open-telemetry#706)

* [recommendationservice] - base image, licensing and diagram update (open-telemetry#700)

* update service metric requirement table (open-telemetry#707)

* update service metric requirement table

* add feature table

* Update emailservice Dockerfile to use alpine and multistage build (open-telemetry#703)

* Update emailservice Dockerfile

Signed-off-by: svrnm <[email protected]>

* Use alpine

Signed-off-by: svrnm <[email protected]>

* Add changelog

Signed-off-by: svrnm <[email protected]>

* newline

Signed-off-by: svrnm <[email protected]>

* Update CHANGELOG.md

* Update .dockerignore

Signed-off-by: svrnm <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>

* Update dockerfile for adservice to use different base images (open-telemetry#705)

* Enable exemplar export/display support (open-telemetry#704)

* Enable exemplar export/display support

Ensure the collector's prometheus endpoint produces exemplars
Ensure that prometheus collects and stores exemplar data
Ensure that grafana will display links to exemplars from dashboards/the explore tab

* Enable exemplars for latency histogram in demo dashboard

* update contributing guide (open-telemetry#711)

* update contributing guide

* fix lint

Co-authored-by: Carter Socha <[email protected]>

* Add random errors in AdService (open-telemetry#694)

* feature(frontend): adding instrumentation metrics (open-telemetry#632)

* feature(frontend): adding instrumentation metrics

* feature(frontend): adding instrumentation metrics

* updating package-lock.json

* Update docker-compose.yml

Co-authored-by: Marc Pichler <[email protected]>

---------

Co-authored-by: Marc Pichler <[email protected]>

* Update CONTRIBUTING.md (open-telemetry#720)

* fix metrics import (open-telemetry#721)

Signed-off-by: Pierre Tessier <[email protected]>

* Update .env (open-telemetry#722)

* Updated demo link for Sumo Logic (open-telemetry#718)

* Add build for arm64 arch (open-telemetry#657)

* Add build for arm64 arch

* Add change to changelog

* enable build on PR

* remove build on pr

---------

Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Carter Socha <[email protected]>
Co-authored-by: Austin Parker <[email protected]>

* [chore] - fix image version (open-telemetry#726)

Remove the `v` prefix from the image version. We now publish images without this prefix.

* Adds caveats to current exemplar support in the demo architecture (open-telemetry#725)

Also, updates collector version: exemplars for the latency histogram produced by the span  metrics processor are now getting exported for all services and endpoints, not just the first one in the metric family.

Co-authored-by: Pierre Tessier <[email protected]>

* Add Sentry (sentry.io) demo to README (open-telemetry#724)

* Add Sentry (sentry.io) demo to README

* use alpha order

---------

Co-authored-by: Pierre Tessier <[email protected]>

* Drop docs folder and adjust links (open-telemetry#730)

* Drop docs folder and adjust links

* Update PULL_REQUEST_TEMPLATE.md

* Add entry to CHANGELOG.md

* README: drop unused logo reference

* add reflection for grpcurl (open-telemetry#735)

* Add cross-compilation for shipping service (open-telemetry#715)

* Add cross-compilation for shipping service

Signed-off-by: svrnm <[email protected]>

* Update CHANGELOG.md

* Update Dockerfile

---------

Signed-off-by: svrnm <[email protected]>

* Ensure all http.server.duration metrics have the same description (open-telemetry#738)

* Add OTel logo to README (open-telemetry#744)

* rename proto package from hipstershop to oteldemo (open-telemetry#740)

* prometheus: honor_labels to have the right job and instance (open-telemetry#743)

Co-authored-by: Carter Socha <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>

* Nit fix contributing guide (open-telemetry#747)

---------

Signed-off-by: svrnm <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Josh Lee <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Carter Socha <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Cedric Ziel <[email protected]>
Co-authored-by: Brett McBride <[email protected]>
Co-authored-by: James Lawrie <[email protected]>
Co-authored-by: Austin Parker <[email protected]>
Co-authored-by: jack-berg <[email protected]>
Co-authored-by: Oscar Reyes <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Pierre Tessier <[email protected]>
Co-authored-by: Pawel Brzoska <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Jared Tan <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Goutham Veeramachaneni <[email protected]>
Co-authored-by: Cijo Thomas <[email protected]>
@cedricziel cedricziel mentioned this pull request Oct 16, 2023
Closed
6 tasks
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@cedricziel @julianocosta89 @cartersocha
Add healthcheck to featureflagservice (open-telemetry#661)
bc2b204 
* Add healthcheck to featureflagservice

In order to assess the health of this central service, compose should perform a check on the service.

* Add changelog entry

Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Carter Socha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianocosta89 julianocosta89 julianocosta89 approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@puckpuck puckpuck puckpuck approved these changes

Assignees
No one assigned
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cedricziel @mic-max @julianocosta89 @puckpuck @fatsheep9146 @cartersocha