Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gradle wrapper validation #518

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Add gradle wrapper validation #518

merged 2 commits into from
Oct 23, 2022

Conversation

trask
Copy link
Member

@trask trask commented Oct 22, 2022

@trask trask requested a review from a team October 22, 2022 18:07
cartersocha
cartersocha approved these changes Oct 22, 2022
View reviewed changes
Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The security risk is interesting. I have noticed files being obscured like the link shows

@cartersocha cartersocha merged commit ce3a8d7 into open-telemetry:main Oct 23, 2022
@trask trask deleted the add-gradle-wrapper-validation branch October 23, 2022 02:19
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@trask @cartersocha
Add gradle wrapper validation (open-telemetry#518)
3ef76e6 
Co-authored-by: Carter Socha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartersocha cartersocha cartersocha approved these changes

@puckpuck puckpuck puckpuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trask @puckpuck @cartersocha