Add resource leak hero scenario. #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! This is cool:
|
julianocosta89
requested changes
Oct 15, 2022
Co-authored-by: Juliano Costa <[email protected]>
Yeah -- incidentally I'm not wedded to the growth here (I think it's probably too quick, it takes about 5 minutes at the current random rate + ^2 growth of the list), I might tweak it to ^1.5 or ^1.2 to get more of a stairstep in growth. |
julianocosta89
approved these changes
Oct 15, 2022
|
Tweaked it a bit and added a memory limit to the service in docker. |
julianocosta89
approved these changes
Oct 17, 2022
fatsheep9146
approved these changes
Oct 17, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* add cache leak failure scenario * add attribute to span * update changelog * Update src/recommendationservice/recommendation_server.py Co-authored-by: Juliano Costa <[email protected]> * add newline * add docs * tweak scenario * add resource limit to force service overlimit * review Co-authored-by: Juliano Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a 'hero scenario' of a resource leak to the Recommendation Service. This scenario implements a naive cache, controlled by the
recommendationCacheflag, as well as a newspan.cache_sizespan attribute. Other changes include adding a restart policy to the container for this service, as the cache will blow up after a few minutes.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes