add feature flags on start #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsloughter Can you offer guidance on how to get Ecto Migrations to wait for a database connection before proceeding instead of doing the |
|
I can't but I can find someone who can. Would be nicer if the docker |
|
ooof... I got caught mid-docs restructuring on this one. Sorry for the commits reverting back and forth there. |
mic-max
approved these changes
Aug 18, 2022
src/featureflagservice/priv/repo/migrations/20220524172636_create_featureflags.exs
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Aug 18, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* add feature flags on start * revert sleep change * document feature flags * feature flag definitions * Revert "document feature flags" This reverts commit c975f5d. * document feature flags * document feature flags * add reference to feature flags * fix nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301
Changes
Inserting the records into the database using Ecto migrations with a default of
falsefor enabled. The user can enable the flag by going to the Feature Flag service web UI http://localhost:8081. As of the creation of this PR only theproductCatalogFailureflag is leveraged in service code. Using migrations means feature flags state will be preserved if you stop/restart the service/demo. The migrations only reset if thepostgres_ffsservice container is recreated with docker compose (usingdocker compose downor the--force-recreateflag)We should merge #315 before this
CHANGELOG.mdupdated for non-trivial changes