add feature flag service to proto file #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
May 20, 2022
|
LGTM with a changelog entry. |
|
Please open an issue to track the overall service addition too |
|
k, will do |
Closed
|
Opened #28 and updated the changelog. |
cartersocha
approved these changes
May 20, 2022
|
Yea, I don't have permissions to merge. |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* add feature flag service to proto file * update changelog for added feature flag service protos
smith
pushed a commit
to smith/opentelemetry-demo
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protos for issue #28
Changes
This adds the feature flag service protos. I figured this was the best place to start with adding this service.
I can open a design discussion issue like the check boxes below say but I thought this might be simply enough to just open a PR. I didn't include anything beyond a feature flag having a name and a bool, to keep it simple. I assume we don't want stuff like variants/experiments/etc, but could easily add them to this PR if they are.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes