-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Simple kubernetes setup #210
Add Simple kubernetes setup #210
Conversation
k8s_local/adservice.yaml
Outdated
spec: | ||
containers: | ||
- name: adservice | ||
image: otel/demo:v0.2.0-alpha-adservice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the image tag version should be a variable, and keep up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this an env var that we set in Makefile
. Let me know if there is a better way to achieve same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Communicated with the author via slack. It was agreed that the pr will be continued after the otel demo helm chart is completed.
I tested this on my Macbook Pro after creating a local cluster via |
@saurabhdes thanks for testing. I made a fix to makes sure env var is set properly in |
thanks @dineshg13 for the fix. I am still having same issues with my kind cluster (could be my machine issue). But i was able to deploy successfully on AKS cluster. Not all services were there as i am running into a separate memory issue for the otel daemon set to run. I will try increasing memory size of AKS nodes. |
Maybe consider only using limit for resources not request to avoid this kind of problem? @dineshg13 |
Although this works, but I think it's the yaml with resources section is still important, since the resources spec is also important observation information. I think maybe a flag to switch between with-resource mode and without-resource mode is better. @dineshg13 @wph95 |
spec: | ||
containers: | ||
- name: adservice | ||
image: otel/demo:${DOCKER_IMAGE_VERSION}-adservice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following #156, the package is now public, we could use ghcr.io/open-telemetry/demo
now.
Closing this in favor of open-telemetry/opentelemetry-helm-charts#280 |
Fixes a part of #153
Adds kubernetes files to test webstore in a
k8s
cluster.Changes
k8s_local
with the setup necessary to run the demo webstore on a k8s cluster.Makefile
to make easy to setup the services ink8s
Cons of the approach:
docker-compose
andk8s
but that is inevitable as some of config are different are different in two environments.