Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and enhance logging support for cart service (C#) #62

Closed
3 tasks
cartersocha opened this issue May 30, 2022 · 3 comments
Closed
3 tasks

Review and enhance logging support for cart service (C#) #62

cartersocha opened this issue May 30, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cartersocha
Copy link
Contributor

As OpenTelemetry Logging has not fully stabilized, this list of requirements may change in future releases.

  • Log events in existing services should be converted to span events where appropriate (i.e., the event occurs within a transaction)
  • Logs should be emitted with OpenTelemetry resources and context for correlation where possible.
  • Logs should be scraped by OpenTelemetry Collectors for further filtering and processing.

Referencing issue: #44

Service: Service: https://github.com/open-telemetry/opentelemetry-demo-webstore/tree/main/src/cartservice

@cartersocha cartersocha added enhancement New feature or request help wanted Extra attention is needed required-for-release labels May 30, 2022
@cartersocha cartersocha changed the title Review and enhance tracing support for cart service (C#) Review and enhance logging support for cart service (C#) May 30, 2022
@cijothomas
Copy link
Member

I can help with this item.
To begin with, I can replace the Console.Write with ILogger calls.,
Then wire up OpenTelemetry with OTLP Exporter.
Then add resources.

Not sure about using SpanEvent vs using dedicated Logging API. Do we have a preference on one vs other?

@cartersocha
Copy link
Contributor Author

From the architecture doc I think our preference is to set this as a span event.

"Services should attach log events to spans where appropriate
E.g., the log occurs during a span transaction"

@austinlparker or @jsirianni feel free to correct me!

@austinlparker
Copy link
Member

Closing this as logs are being pushed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

3 participants