[Cart] Added instrumentation for Asp.Net Core (http server) (#394)

* Add runtime metrics to cartservice * reorder * Add http server metrics for cart service * update doc * bump version * Update src/cartservice/src/cartstore/RedisCartStore.cs Co-authored-by: Reiley Yang <[email protected]> * Update src/cartservice/src/Startup.cs * Update src/cartservice/src/Startup.cs Co-authored-by: Reiley Yang <[email protected]>
open-telemetry · Sep 30, 2022 · b6e75ee · b6e75ee
1 parent 6d9b7ce
commit b6e75ee
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/docs/metric_service_features.md b/docs/metric_service_features.md
@@ -9,7 +9,7 @@ Emoji Legend
 | Service         | Language        | Instrumentation Libraries | Manual Metric Creation | Collector Agent Metric Transformation | Push Metrics   | SLO Metrics    | Multiple Manual Metric Instruments |
 |-----------------|-----------------|---------------------------|------------------------|---------------------------------------|----------------|----------------|------------------------------------|
 | Ad              | Java            | :construction:            | :construction:         | :construction:                        | :construction: | :construction: | :construction:                     |
-| Cart            | .NET            | :construction:            | :construction:         | :construction:                        | :construction: | :construction: | :construction:                     |
+| Cart            | .NET            | :100:                     | :construction:         | :construction:                        | :construction: | :construction: | :construction:                     |
 | Checkout        | Go              | :construction:            | :construction:         | :construction:                        | :construction: | :construction: | :construction:                     |
 | Currency        | C++             | :construction:            | :construction:         | :construction:                        | :construction: | :construction: | :construction:                     |
 | Email           | Ruby            | :construction:            | :construction:         | :construction:                        | :construction: | :construction: | :construction:                     |

diff --git a/src/cartservice/src/Startup.cs b/src/cartservice/src/Startup.cs
@@ -50,9 +50,10 @@ public void ConfigureServices(IServiceCollection services)
             .AddHttpClientInstrumentation()
             .AddOtlpExporter());
 
-            services.AddOpenTelemetryMetrics(builder =>
-                builder.AddRuntimeInstrumentation()
-                       .AddOtlpExporter());
+        services.AddOpenTelemetryMetrics(builder =>
+            builder.AddRuntimeInstrumentation()
+                   .AddAspNetCoreInstrumentation()
+                   .AddOtlpExporter());
 
         services.AddGrpc();
         services.AddGrpcHealthChecks()

diff --git a/src/cartservice/src/cartservice.csproj b/src/cartservice/src/cartservice.csproj
@@ -8,7 +8,7 @@
     <PackageReference Include="Grpc.AspNetCore" Version="2.44.0" />
     <PackageReference Include="Grpc.AspNetCore.HealthChecks" Version="2.46.0" />
     <PackageReference Include="StackExchange.Redis" Version="2.5.43" />
-    <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.3.0" />
+    <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.3.1" />
     <PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc9.4" />
     <PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc9.4" />
     <PackageReference Include="OpenTelemetry.Instrumentation.GrpcNetClient" Version="1.0.0-rc9.4" />

diff --git a/src/cartservice/src/cartstore/RedisCartStore.cs b/src/cartservice/src/cartstore/RedisCartStore.cs
@@ -101,7 +101,7 @@ private void EnsureRedisConnected()
                 redis.ConnectionRestored += (o, e) =>
                 {
                     isRedisConnectionOpened = true;
-                    Console.WriteLine("Connection to redis was retored successfully");
+                    Console.WriteLine("Connection to redis was restored successfully.");
                 };
                 redis.ConnectionFailed += (o, e) =>
                 {