Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP change default port number #522

Merged
merged 1 commit into from
Jan 20, 2021
Merged

OTLP change default port number #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/otlp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ receivers:
otlp:
protocols:
grpc:
endpoint: localhost:55680
endpoint: localhost:4317
exporters:
zipkin:
endpoint: "http://localhost:9411/api/v2/spans"
Expand All @@ -26,6 +26,6 @@ service:
exporters: [zipkin]
```

Note that the OTLP exporter connects to the Collector at `localhost:55680` by default. This can be changed with first argument from command-line, for example: `./example_otlp gateway.docker.internal:55680`.
Note that the OTLP exporter connects to the Collector at `localhost:4317` by default. This can be changed with first argument from command-line, for example: `./example_otlp gateway.docker.internal:4317`.

Once you have the Collector running, see [CONTRIBUTING.md](../../CONTRIBUTING.md) for instructions on building and running the example.
6 changes: 3 additions & 3 deletions exporters/otlp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ auto exporter = std::unique_ptr<sdktrace::SpanExporter>(new otlp::OtlpExporter(o

### Configuration options

| Option | Default |
| ------------ |------------------ |
| `endpoint` | `localhost:55680` |
| Option | Default |
| ------------ |----------------- |
| `endpoint` | `localhost:4317` |

## Example

Expand Down
2 changes: 1 addition & 1 deletion exporters/otlp/include/opentelemetry/exporters/otlp/otlp_exporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace otlp
struct OtlpExporterOptions
{
// The endpoint to export to. By default the OpenTelemetry Collector's default endpoint.
std::string endpoint = "localhost:55680";
std::string endpoint = "localhost:4317";
};

/**
Expand Down