Upgrade CMake to 3.15.2 for Linux #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomsonTan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
==========================================
+ Coverage 94.45% 94.46% +0.01%
==========================================
Files 189 189
Lines 8388 8388
==========================================
+ Hits 7923 7924 +1
+ Misses 465 464 -1
|
lalitb
approved these changes
Jan 15, 2021
pyohannes
approved these changes
Jan 15, 2021
maxgolov
reviewed
Jan 16, 2021
maxgolov
approved these changes
Jan 16, 2021
|
It's a binary installer. Ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows build installs CMake version 3.15.2 (see below link), so upgrade Linux to the same version. This version upgrade for Linux is helpful because the CMake from
apt installon Ubuntu 18.10 is 3.10, and this version of CMake doesn't support installation from submodule (this affects gRPC installation from source tree, see here).https://github.com/open-telemetry/opentelemetry-cpp/blob/master/ci/setup_windows_cmake.ps1#L4