Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement for OTLP example #447

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Improvement for OTLP example #447

merged 2 commits into from
Dec 17, 2020

Conversation

TomRoSystems
Copy link
Member

  • added command line argument for specifying endpoint other than default localhost:55680

@TomRoSystems
Improvement for OTLP example
701d948 
- added command line argument for specyfing endpoint other than default localhost:55680
@TomRoSystems TomRoSystems requested a review from a team December 14, 2020 11:34
@TomRoSystems TomRoSystems mentioned this pull request Dec 14, 2020
Closed
@codecov
Copy link

codecov bot commented Dec 14, 2020 •
edited
Loading

Codecov Report

Merging #447 (980e51c) into master (17c1c80) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files         182      182           
  Lines        7853     7853           
=======================================
  Hits         7398     7398           
  Misses        455      455

@maxgolov maxgolov added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Dec 15, 2020
@lalitb lalitb requested a review from jsuereth December 15, 2020 06:48
@lalitb lalitb merged commit cf461fd into open-telemetry:master Dec 17, 2020
kxyr pushed a commit to open-o11y/opentelemetry-cpp that referenced this pull request Dec 22, 2020
@TomRoSystems @lalitb
Improvement for OTLP example (open-telemetry#447)
46b7664 
- added command line argument for specyfing endpoint other than default localhost:55680

Co-authored-by: Lalit Kumar Bhasin <[email protected]>
@TomRoSystems TomRoSystems mentioned this pull request Feb 11, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgolov maxgolov maxgolov approved these changes

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth

Assignees
No one assigned
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomRoSystems @ThomsonTan @lalitb @maxgolov