Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alolita as a Triager #411

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Add alolita as a Triager #411

merged 1 commit into from
Dec 2, 2020

Conversation

reyang
Copy link
Member

@reyang reyang commented Dec 1, 2020

@alolita has been helping multiple projects across the OpenTelemetry community. She has been one of the key stakeholders of the OpenTelemetry C++ metrics prototype, and now driving the C++ logging prototype.

Related to #410.

https://github.com/open-telemetry/community/blob/master/community-membership.md#triager

@reyang reyang requested review from a team and alolita December 1, 2020 18:24
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #411 (221449c) into master (2a516ad) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   94.75%   94.74%   -0.02%     
==========================================
  Files         175      175              
  Lines        7591     7591              
==========================================
- Hits         7193     7192       -1     
- Misses        398      399       +1     
Impacted Files Coverage Δ
sdk/test/metrics/counter_aggregator_test.cc 98.21% <0.00%> (-1.79%) ⬇️

@alolita
Copy link
Member

alolita commented Dec 2, 2020

Thanks @reyang look forward to helping as triager.

Copy link
Member

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ty!

@lalitb
Copy link
Member

lalitb commented Dec 2, 2020

@alolita Thanks for approving. Have added you to cpp-approver team, as we don't have separate triage team yet.

@lalitb lalitb merged commit 26dbde3 into master Dec 2, 2020
@reyang reyang deleted the reyang/triager branch January 20, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants