Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API/SDK] Provider cleanup #2664

Merged
merged 25 commits into from
Jun 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
marcalff committed Jun 3, 2024
commit 75adfa0c4aea4c2ec059bb3f9d7d0d3f9d4da480
5 changes: 5 additions & 0 deletions examples/metrics_simple/metrics_ostream.cc
Original file line number Diff line number Diff line change
@@ -107,7 +107,12 @@ void InitMetrics(const std::string &name)
provider->AddView(std::move(histogram_instrument_selector), std::move(histogram_meter_selector),
std::move(histogram_view));

#ifdef OPENTELEMETRY_DEPRECATED_SDK_FACTORY
std::shared_ptr<opentelemetry::metrics::MeterProvider> api_provider(std::move(u_provider));
#else
std::shared_ptr<opentelemetry::metrics::MeterProvider> api_provider(std::move(provider));
#endif /* OPENTELEMETRY_DEPRECATED_SDK_FACTORY */

metrics_api::Provider::SetMeterProvider(api_provider);
}

13 changes: 13 additions & 0 deletions examples/otlp/file_log_main.cc
Original file line number Diff line number Diff line change
@@ -41,8 +41,13 @@ namespace
opentelemetry::exporter::otlp::OtlpFileExporterOptions opts;
opentelemetry::exporter::otlp::OtlpFileLogRecordExporterOptions log_opts;

#ifdef OPENTELEMETRY_DEPRECATED_SDK_FACTORY
std::shared_ptr<opentelemetry::trace::TracerProvider> tracer_provider;
std::shared_ptr<opentelemetry::logs::LoggerProvider> logger_provider;
#else
std::shared_ptr<opentelemetry::sdk::trace::TracerProvider> tracer_provider;
std::shared_ptr<opentelemetry::sdk::logs::LoggerProvider> logger_provider;
#endif /* OPENTELEMETRY_DEPRECATED_SDK_FACTORY */

void InitTracer()
{
@@ -61,7 +66,11 @@ void CleanupTracer()
// We call ForceFlush to prevent to cancel running exportings, It's optional.
if (tracer_provider)
{
#ifdef OPENTELEMETRY_DEPRECATED_SDK_FACTORY
static_cast<opentelemetry::sdk::trace::TracerProvider *>(tracer_provider.get())->ForceFlush();
#else
tracer_provider->ForceFlush();
#endif /* OPENTELEMETRY_DEPRECATED_SDK_FACTORY */
}

tracer_provider.reset();
@@ -85,7 +94,11 @@ void CleanupLogger()
// We call ForceFlush to prevent to cancel running exportings, It's optional.
if (logger_provider)
{
#ifdef OPENTELEMETRY_DEPRECATED_SDK_FACTORY
static_cast<opentelemetry::sdk::logs::LoggerProvider *>(logger_provider.get())->ForceFlush();
#else
logger_provider->ForceFlush();
#endif /* OPENTELEMETRY_DEPRECATED_SDK_FACTORY */
}

logger_provider.reset();
15 changes: 10 additions & 5 deletions examples/otlp/file_main.cc
Original file line number Diff line number Diff line change
@@ -4,13 +4,10 @@
#include "opentelemetry/exporters/otlp/otlp_file_exporter_factory.h"
#include "opentelemetry/sdk/trace/processor.h"
#include "opentelemetry/sdk/trace/simple_processor_factory.h"
#include "opentelemetry/sdk/trace/tracer_provider.h"
#include "opentelemetry/sdk/trace/tracer_provider_factory.h"
#include "opentelemetry/trace/provider.h"

// sdk::TracerProvider is just used to call ForceFlush and prevent to cancel running exportings when
// destroy and shutdown exporters.It's optional to users.
#include "opentelemetry/sdk/trace/tracer_provider.h"

#include <iostream>
#include <string>
#include <utility>
@@ -29,7 +26,11 @@ namespace
{
opentelemetry::exporter::otlp::OtlpFileExporterOptions opts;

#ifdef OPENTELEMETRY_DEPRECATED_SDK_FACTORY
std::shared_ptr<opentelemetry::trace::TracerProvider> provider;
#else
std::shared_ptr<opentelemetry::sdk::trace::TracerProvider> provider;
#endif /* OPENTELEMETRY_DEPRECATED_SDK_FACTORY */

void InitTracer()
{
@@ -48,7 +49,11 @@ void CleanupTracer()
// We call ForceFlush to prevent to cancel running exportings, It's optional.
if (provider)
{
provider->ForceFlush(std::chrono::milliseconds(10000));
#ifdef OPENTELEMETRY_DEPRECATED_SDK_FACTORY
static_cast<opentelemetry::sdk::trace::TracerProvider *>(provider.get())->ForceFlush();
#else
provider->ForceFlush();
#endif /* OPENTELEMETRY_DEPRECATED_SDK_FACTORY */
}

provider.reset();