Waiting a longer time when run unit tests of http client, which may take a long time when run under valgrind. #1171
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 174 174
Lines 6404 6404
=======================================
Hits 5974 5974
Misses 430 430
|
| @@ -251,7 +251,7 @@ TEST_F(OtlpHttpLogExporterTestPeer, ExportJsonIntegrationTest) | |||
| report_span_id.assign(span_id_hex, sizeof(span_id_hex)); | |||
| } | |||
|
|
|||
| ASSERT_TRUE(waitForRequests(8, old_count + 1)); | |||
| ASSERT_TRUE(waitForRequests(30, old_count + 1)); | |||
There was a problem hiding this comment.
interesting. We started with 2, then 8, and now 30. Didn't know it's that slow with Valgrind :)
There was a problem hiding this comment.
I found otlp http client test under valgrind takes 6s most of the time. The //sdk/test/_metrics:metric_instrument_test take the longest time(almost 1minute). But sometime it takes more time to finish, maybe the CI node is busy at that time?
There was a problem hiding this comment.
Why do we need to increase the HTTP wait time as part of this PR if it's 6 secs most of the time even with valgrind? We should eventually remove the old metrics tests once new implementation is ready.
There was a problem hiding this comment.
This failure is happening every now and then in my PR recently.
There was a problem hiding this comment.
We can merge this PR if that's the case. If the problem persists, we can think of mocking the HTTP responses instead of using a real server.
|
@owent - can you please rebase this PR with main, to allow merging. |
…ake a long time when run under valgrind. Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
owent
force-pushed
the
propagating_resource_through_logger_provider
branch
from
7c70e6b to
e5d9c92
Compare
Done |
Signed-off-by: owentou [email protected]
Fixes #1049
Changes
Increase timeout for http client. We find 8s is not enough sometime.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes