Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etw logger test bazel #1148

Merged
merged 1 commit into from
Dec 17, 2021
Merged

etw logger test bazel #1148

merged 1 commit into from
Dec 17, 2021

Conversation

esigo
Copy link
Member

@esigo esigo commented Dec 17, 2021

Fixes etw logger bazel

Changes

Adds etw logger bazel.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #1148 (2b7aaf8) into main (b021bd6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1148   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files         165      165           
  Lines        6229     6229           
=======================================
  Hits         5817     5817           
  Misses        412      412

@esigo esigo marked this pull request as ready for review December 17, 2021 14:02
@esigo esigo requested a review from a team December 17, 2021 14:02
lalitb
lalitb approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ThomsonTan ThomsonTan merged commit f60eec2 into open-telemetry:main Dec 17, 2021
@esigo esigo deleted the etw-logger-test-bazel branch December 17, 2021 19:22
This was referenced Jan 25, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esigo @ThomsonTan @lalitb