Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: link the module against libstd++ and the (used) opentelemetry libraries in the nginx build #58

Merged
merged 1 commit into from
Sep 24, 2021
Merged

nginx: link the module against libstd++ and the (used) opentelemetry libraries in the nginx build #58

merged 1 commit into from
Sep 24, 2021

Conversation

tobiasstadler
Copy link
Member

No description provided.

@tobiasstadler tobiasstadler requested a review from a team September 23, 2021 07:55
@seemk
Copy link
Contributor

seemk commented Sep 23, 2021

Thanks, are these libraries enough? See the discussion at #52

@tobiasstadler
Copy link
Member Author

Yes, I think so. At least it is working for me that way (building opentelemtry as shared libraries)

@tobiasstadler
Copy link
Member Author

If (for other use cases) there is something missing we can still add it later

@seemk seemk merged commit 86bea27 into open-telemetry:main Sep 24, 2021
@tobiasstadler tobiasstadler deleted the ngx_module_libs branch September 24, 2021 11:52
@tobiasstadler
Copy link
Member Author

Thank You!

@tobiasstadler tobiasstadler mentioned this pull request May 4, 2022
Closed
6 tasks
@marcalff marcalff added the instrumentation:nginx Nginx module label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemk seemk seemk approved these changes

Assignees
No one assigned
Labels
instrumentation:nginx Nginx module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasstadler @seemk @marcalff