Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translator/conventions: add telemetry.sdk.* #997

Merged
merged 1 commit into from
May 21, 2020

Conversation

axw
Copy link
Contributor

@axw axw commented May 20, 2020

Description:

Add constants to translator/conventions for Telemetry SDK resource attributes.

@axw
Copy link
Contributor Author

axw commented May 20, 2020

It looks like library.* was renamed to telemetry.sdk.* in open-telemetry/opentelemetry-specification#494. Should I move the existing AttributeLibrary* to translator/conventions/opencensus.go?

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #997 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
+ Coverage   85.65%   85.68%   +0.03%     
==========================================
  Files         188      188              
  Lines       13147    13147              
==========================================
+ Hits        11261    11265       +4     
+ Misses       1435     1432       -3     
+ Partials      451      450       -1     
Impacted Files Coverage Δ
service/service.go 49.81% <0.00%> (+0.72%) ⬆️
translator/internaldata/resource_to_oc.go 76.47% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c72459...a40608e. Read the comment docs.

@axw
Copy link
Contributor Author

axw commented May 20, 2020

@bogdandrutu could you please merge? I am not authorised.

@bogdandrutu bogdandrutu merged commit a02ed5c into open-telemetry:master May 21, 2020
@axw axw deleted the conventions-telemetry-sdk branch May 21, 2020 01:28
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants