Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configgrpc] Remove deprecated func, add ToServer with context #9787

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Removes deprecated ToServer.
Deprecate ToServerContext
Add new ToServer with context.Context.

Link to tracking Issue:
Related to #9490

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (3b5aee0) to head (54ef514).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9787      +/-   ##
==========================================
+ Coverage   90.98%   91.03%   +0.05%     
==========================================
  Files         353      353              
  Lines       18648    18702      +54     
==========================================
+ Hits        16967    17026      +59     
+ Misses       1354     1348       -6     
- Partials      327      328       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth TylerHelmuth marked this pull request as ready for review March 18, 2024 21:05
@TylerHelmuth TylerHelmuth requested review from a team and jpkrohling March 18, 2024 21:05
@dmitryax dmitryax merged commit fc4c13d into open-telemetry:main Mar 20, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 20, 2024
@TylerHelmuth TylerHelmuth deleted the configgrpc-remove-deprecated-func branch March 20, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants