[chore] Fix an incorrect automatic replace made by a bot in otel-config.yml
#9746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an incorrect automatic replace made in this PR https://github.com/open-telemetry/opentelemetry-collector/pull/9680/files#diff-c7c8156618a7f8126b25ca1bdfde3e172a0d2cb75c533d63a71617ae2a5c54ae apparently by a bot. I've taken the previous value which seems right.
|
Lol. Thanks for fixing this! Happened in 998f64d @open-telemetry/collector-maintainers. do you have any idea how it's possible? :) |
|
Looks like |
|
Submitted #9748 |
codeboten
approved these changes
Mar 12, 2024
Haha, it happens! Thanks for the quick review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9746 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 353 353
Lines 18630 18630
=======================================
Hits 16947 16947
Misses 1356 1356
Partials 327 327 ☔ View full report in Codecov by Sentry. |
tomasmota
pushed a commit
to tomasmota/opentelemetry-collector
that referenced
this pull request
Mar 14, 2024
…fig.yml` (open-telemetry#9746) This PR fixes an incorrect automatic replace made in the `otel-config.yml` file in this [pull request](https://github.com/open-telemetry/opentelemetry-collector/pull/9680/files#diff-c7c8156618a7f8126b25ca1bdfde3e172a0d2cb75c533d63a71617ae2a5c54ae) by a bot. I've taken the previous value which seems right. Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect automatic replace made in the
otel-config.ymlfile in this pull request by a bot. I've taken the previous value which seems right.